[GitHub] [samza] cameronlee314 commented on a change in pull request #1047: SAMZA-2210: Initial majority migration for injecting classloader when doing reflection

[GitBox <gi...@apache.org>]

cameronlee314 commented on a change in pull request #1047: SAMZA-2210: Initial majority migration for injecting classloader when doing reflection 
URL: https://github.com/apache/samza/pull/1047#discussion_r290042422
 
 

 ##########
 File path: samza-core/src/main/java/org/apache/samza/clustermanager/AbstractContainerAllocator.java
 ##########
 @@ -51,9 +51,13 @@
    * Config and derived config objects
    */
   private final TaskConfig taskConfig;
-
   private final Config config;
 
+  /**
+   * Classloader for creating objects from config
+   */
+  private final ClassLoader classLoaderForConfigObjects;
 
 Review comment:
   `pluginClassloader` is a cleaner name. Thanks for the suggestion.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services