You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/09/04 22:29:53 UTC
[GitHub] [lucene-solr] jtibshirani opened a new pull request #1833: LUCENE-9501: Fix invariant violation in IndexSortSortedNumericDocValuesRangeQuery.
jtibshirani opened a new pull request #1833:
URL: https://github.com/apache/lucene-solr/pull/1833
Previously the DocIdSetIterator returned an old value for docID even after
advance returned NO_MORE_DOCS. This violates the DocIdSetIterator contract and
made it possible for the iterator's advance method to be called even after it
was already exhausted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mayya-sharipova merged pull request #1833: LUCENE-9501: Fix invariant violation in IndexSortSortedNumericDocValuesRangeQuery.
Posted by GitBox <gi...@apache.org>.
mayya-sharipova merged pull request #1833:
URL: https://github.com/apache/lucene-solr/pull/1833
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] jtibshirani commented on a change in pull request #1833: LUCENE-9501: Fix invariant violation in IndexSortSortedNumericDocValuesRangeQuery.
Posted by GitBox <gi...@apache.org>.
jtibshirani commented on a change in pull request #1833:
URL: https://github.com/apache/lucene-solr/pull/1833#discussion_r483868710
##########
File path: lucene/sandbox/src/test/org/apache/lucene/search/TestIndexSortSortedNumericDocValuesRangeQuery.java
##########
@@ -65,7 +65,7 @@ public void testSameHitsAsPointRangeQuery() throws IOException {
iw.deleteDocuments(LongPoint.newRangeQuery("idx", 0L, 10L));
}
final IndexReader reader = iw.getReader();
- final IndexSearcher searcher = newSearcher(reader, false);
+ final IndexSearcher searcher = newSearcher(reader);
Review comment:
This isn't critical for test coverage, but it seemed off that we had disabled wrapping the reader.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org