You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Vivek Ratnavel Subramanian <vi...@gmail.com> on 2017/01/24 21:15:01 UTC

Review Request 55891: Axis units and aggregators are wrong in some graphs of ambari grafana dashboards

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55891/
-----------------------------------------------------------

Review request for Ambari, Aravindan Vijayan, Jaimin Jetly, Sid Wagle, and Yusaku Sako.


Bugs: AMBARI-19699
    https://issues.apache.org/jira/browse/AMBARI-19699


Repository: ambari


Description
-------

Need to fix the following:
ReadAllQuery.HostRoleCommandEntity is missing a Y axis.
Total Cache Misses Y axis is wrong should not be time.
Remove Max aggregator from all metrics (JVM dashboard)
Cache Hits and Misses rate graphs aren't in the same units


Diffs
-----

  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/default/grafana-ambari-server-database.json aea7520 
  ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/default/grafana-ambari-server.json 2cdd6d9 

Diff: https://reviews.apache.org/r/55891/diff/


Testing
-------

Verified Manually.


Thanks,

Vivek Ratnavel Subramanian


Re: Review Request 55891: Axis units and aggregators are wrong in some graphs of ambari grafana dashboards

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55891/#review162860
-----------------------------------------------------------


Ship it!




Ship It!

- Sid Wagle


On Jan. 24, 2017, 9:15 p.m., Vivek Ratnavel Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55891/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2017, 9:15 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jaimin Jetly, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-19699
>     https://issues.apache.org/jira/browse/AMBARI-19699
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Need to fix the following:
> ReadAllQuery.HostRoleCommandEntity is missing a Y axis.
> Total Cache Misses Y axis is wrong should not be time.
> Remove Max aggregator from all metrics (JVM dashboard)
> Cache Hits and Misses rate graphs aren't in the same units
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/default/grafana-ambari-server-database.json aea7520 
>   ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/default/grafana-ambari-server.json 2cdd6d9 
> 
> Diff: https://reviews.apache.org/r/55891/diff/
> 
> 
> Testing
> -------
> 
> Verified Manually.
> 
> 
> Thanks,
> 
> Vivek Ratnavel Subramanian
> 
>