[GitHub] [druid] imply-cheddar commented on a diff in pull request #13506: Sort-merge join and hash shuffles for MSQ.

["imply-cheddar (via GitHub)" <gi...@apache.org>]

imply-cheddar commented on code in PR #13506:
URL: https://github.com/apache/druid/pull/13506#discussion_r1121184142


##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/WorkerContext.java:
##########
@@ -73,4 +74,9 @@
   DruidNode selfNode();
 
   Bouncer processorBouncer();
+
+  default File tempDir(int stageNumber, String id)

Review Comment:
   I like consistency.  If it's always `tmp` then it's much easier to say that next time it should be `tmp` as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org