You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by "Michael Vorburger (Jira)" <ji...@apache.org> on 2020/11/28 19:34:00 UTC
[jira] [Updated] (FINERACT-1270) Unify Fineract 3 (!) different
email sender utilities
[ https://issues.apache.org/jira/browse/FINERACT-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Vorburger updated FINERACT-1270:
----------------------------------------
Description:
While looking into addressing FINERACT-1092, I've just noticed that the Fineract code base has not 1 and not 2 but 3 (!) classes which send email:
* org.apache.fineract.infrastructure.core.service.GmailBackedPlatformEmailService
* org.apache.fineract.infrastructure.campaigns.email.service.EmailMessageJobEmailServiceImpl
* org.apache.fineract.infrastructure.reportmailingjob.service.ReportMailingJobEmailServiceImpl
The best thing is that 2 of those use {{org.springframework.mail.javamail}} whereas the 3rd (and probably oldest?) uses {{org.apache.commons.mail}} instead.
They, apparently, also use 3 completely different mail server configurations in the database! This doesn't make any sense - I cannot imagine anyone wanting to use 3 different mail server for 3 purposes.
Let's merge all this?
was:
While looking into addressing FINERACT-1092, I've just noticed that the Fineract code base has not 1 and not 2 but 3 (!) classes which send email:
* org.apache.fineract.infrastructure.core.service.GmailBackedPlatformEmailService
* org.apache.fineract.infrastructure.campaigns.email.service.EmailMessageJobEmailServiceImpl
* org.apache.fineract.infrastructure.reportmailingjob.service.ReportMailingJobEmailServiceImpl
The best thing is that 2 of those use {{org.springframework.mail.javamail}} whereas the 3rd (and probably oldest?) uses {{org.apache.commons.mail}} instead.
They, apparently, also use 2 completely different configurations!
Let's merge all this?
> Unify Fineract 3 (!) different email sender utilities
> -----------------------------------------------------
>
> Key: FINERACT-1270
> URL: https://issues.apache.org/jira/browse/FINERACT-1270
> Project: Apache Fineract
> Issue Type: Improvement
> Reporter: Michael Vorburger
> Priority: Major
>
> While looking into addressing FINERACT-1092, I've just noticed that the Fineract code base has not 1 and not 2 but 3 (!) classes which send email:
> * org.apache.fineract.infrastructure.core.service.GmailBackedPlatformEmailService
> * org.apache.fineract.infrastructure.campaigns.email.service.EmailMessageJobEmailServiceImpl
> * org.apache.fineract.infrastructure.reportmailingjob.service.ReportMailingJobEmailServiceImpl
> The best thing is that 2 of those use {{org.springframework.mail.javamail}} whereas the 3rd (and probably oldest?) uses {{org.apache.commons.mail}} instead.
> They, apparently, also use 3 completely different mail server configurations in the database! This doesn't make any sense - I cannot imagine anyone wanting to use 3 different mail server for 3 purposes.
> Let's merge all this?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)