[GitHub] [rocketmq] ni-ze commented on a change in pull request #3746: [ISSUE #3681]Add the command to check master-slave synchronization status.

[GitBox <gi...@apache.org>]

ni-ze commented on a change in pull request #3746:
URL: https://github.com/apache/rocketmq/pull/3746#discussion_r782657839



##########
File path: tools/src/main/java/org/apache/rocketmq/tools/command/broker/GetMasterSlaveDiffCommand.java
##########
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.rocketmq.tools.command.broker;
+
+import org.apache.commons.cli.CommandLine;
+import org.apache.commons.cli.Option;
+import org.apache.commons.cli.Options;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.rocketmq.common.MixAll;
+import org.apache.rocketmq.common.protocol.body.ClusterInfo;
+import org.apache.rocketmq.common.protocol.route.BrokerData;
+import org.apache.rocketmq.remoting.RPCHook;
+import org.apache.rocketmq.tools.admin.DefaultMQAdminExt;
+import org.apache.rocketmq.tools.command.SubCommand;
+import org.apache.rocketmq.tools.command.SubCommandException;
+
+import java.util.HashMap;
+import java.util.Set;
+
+public class GetMasterSlaveDiffCommand implements SubCommand {
+    @Override
+    public String commandName() {
+        return "getMasterSlaveDiff";
+    }
+
+    @Override
+    public String commandDesc() {
+        return "Get number of bytes that slave falls behind master.";
+    }
+
+    @Override
+    public Options buildCommandlineOptions(final Options options) {
+        Option opt = new Option("b", "brokerName", true, "Broker Name");
+        opt.setRequired(false);
+        options.addOption(opt);
+
+        opt = new Option("c", "clusterName", true, "Cluster Name");
+        opt.setRequired(false);
+        options.addOption(opt);
+
+        return options;
+    }
+
+    @Override
+    public void execute(final CommandLine commandLine, final Options options,
+        final RPCHook rpcHook) throws SubCommandException {
+        DefaultMQAdminExt defaultMQAdminExt = new DefaultMQAdminExt(rpcHook);
+        defaultMQAdminExt.setInstanceName(Long.toString(System.currentTimeMillis()));
+        try {
+            if (commandLine.hasOption('b')) {
+                String brokerAddr = commandLine.getOptionValue('b').trim();
+                defaultMQAdminExt.start();
+                printDiffForBroker(defaultMQAdminExt, brokerAddr);
+            } else if (commandLine.hasOption('c')) {
+                String clusterName = commandLine.getOptionValue('c').trim();
+                defaultMQAdminExt.start();
+                printDiffForCluster(defaultMQAdminExt, clusterName);
+            }
+        } catch (Exception e) {
+            throw new SubCommandException(this.getClass().getSimpleName() + " command failed", e);
+        } finally {
+            defaultMQAdminExt.shutdown();
+        }
+    }
+
+    private void printDiffForCluster(final DefaultMQAdminExt defaultMQAdminExt, String clusterName) throws SubCommandException {
+        ClusterInfo clusterInfo = null;
+        try {
+            clusterInfo = defaultMQAdminExt.examineBrokerClusterInfo();
+        } catch (Exception e) {
+            throw new SubCommandException(this.getClass().getSimpleName() + " command failed", e);
+        }
+
+        HashMap<String, Set<String>> clusterMap = clusterInfo.getClusterAddrTable();
+        Set<String> brokerNameSet = clusterMap.get(clusterName);
+        if (brokerNameSet == null || brokerNameSet.isEmpty()) {
+            System.out.printf("Can not find brokers for the cluster named %s!%n", clusterName);
+            return;
+        } else {
+            System.out.printf("%-24s %-24s %-24s %-14s%n",
+                    "#Cluster Name",
+                    "#Broker Name",
+                    "#Broker Address(Master)",
+                    "#Diff(Bytes)"
+            );
+            for (String brokerName : brokerNameSet) {
+                HashMap<String/* brokerName */, BrokerData> brokerAddrTable = clusterInfo.getBrokerAddrTable();
+                BrokerData brokerData;
+                if ((brokerData = brokerAddrTable.get(brokerName)) == null) {
+                    continue;
+                } else {
+                    String masterBrokerAddr = brokerData.getBrokerAddrs().get(MixAll.MASTER_ID);
+                    if (StringUtils.isBlank(masterBrokerAddr))
+                        continue;
+                    try {

Review comment:
       suggest all code in loop moving into try catch block. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org