[GitHub] [nifi] turcsanyip commented on a diff in pull request #6055: NIFI-10025 Add basic auth support for HortonworksSchemaRegistry

[GitBox <gi...@apache.org>]

turcsanyip commented on code in PR #6055:
URL: https://github.com/apache/nifi/pull/6055#discussion_r883751082


##########
nifi-nar-bundles/nifi-standard-services/nifi-hwx-schema-registry-bundle/nifi-hwx-schema-registry-service/src/main/java/org/apache/nifi/schemaregistry/hortonworks/HortonworksSchemaRegistry.java:
##########
@@ -66,12 +66,12 @@
 @CapabilityDescription("Provides a Schema Registry Service that interacts with a Hortonworks Schema Registry, available at https://github.com/hortonworks/registry")
 public class HortonworksSchemaRegistry extends AbstractControllerService implements SchemaRegistry {
     private static final Set<SchemaField> schemaFields = EnumSet.of(SchemaField.SCHEMA_NAME,
-            SchemaField.SCHEMA_BRANCH_NAME,
-            SchemaField.SCHEMA_TEXT,
-            SchemaField.SCHEMA_TEXT_FORMAT,
-            SchemaField.SCHEMA_IDENTIFIER,
-            SchemaField.SCHEMA_VERSION,
-            SchemaField.SCHEMA_VERSION_ID);
+        SchemaField.SCHEMA_BRANCH_NAME,

Review Comment:
   @tpalfy Please do not change the indentation / reformat the code if it is not necessary. The line continuation indent should be 2 x normal indent, so I think the original was fine.
   
   Otherwise, the change looks good to me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org