You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/03/31 08:59:27 UTC

[GitHub] [systemds] sebwrede commented on pull request #1193: [SYSTEMDS-2904] Federated ternary instruction

sebwrede commented on pull request #1193:
URL: https://github.com/apache/systemds/pull/1193#issuecomment-810901079


   I think the latest commit is a work around for not having a BinaryMatrixMatrixFEDInstruction with federated right input. I had this case in another branch which has not been added to master. I made some changes to your branch, but I cannot push to your fork. Instead, I added it as a branch to my own fork. You can find it here: https://github.com/sebwrede/systemds/commit/bbf679cae0a73a2e8eee7dbc16efff7e998bba36
   I think it is best not to adapt the algorithms to prevent calling the federated instructions with right input. If you agree, you can merge from my branch or develop your own solution for it. 
   When this is done, I think this PR looks good and I can merge it later. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org