[jira] [Commented] (PHOENIX-6611) Multiple IndexTool bugs

["Istvan Toth (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-6611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17459361#comment-17459361 ] 

Istvan Toth commented on PHOENIX-6611:
--------------------------------------

Some comments on PR:

There is a lot of noise, due to the removal of the directApi option, and movinf the VERIFIED/UNVERIFIED constants to QueryConstants.
The interesting stuff is in 

IndexTool
FormatToBytesWritableMapper
PhoenixIndexImportDirectMapper
IndexUtil
IndexToolIT
IndexBuildTimestampIT.


> Multiple IndexTool bugs
> -----------------------
>
>                 Key: PHOENIX-6611
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6611
>             Project: Phoenix
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 5.2.0
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Critical
>
> While fixing a trivial problem I introduced in PHOENIX-6601, I have expanded the ITs, and found a several bugs with IndexTool.
> * Indexes generated by PhoenixIndexImportDirectReducer do not handle rows modified after the index table was created. (related to PHOENIX-5375, PHOENIX-5376)
> * Global secondary index cells generated by PhoenixIndexImportDirectReducer do not have the VERIFIED flag set
> * IndexTool cannot be run on the same table multiple  withh -snapshot, unless the snapshot is manually deleted. 
> * Global secondary index cells on transactional tables do not have the VERIFIED flag set.
> * Invalid snapshot name is generated for snapshot with namespace mapping enabled. (PHOENIX-6601 regression)
> Some more test issues:
> * IndexToolIT is not run with snapshots, or with namespace mapping enabled.
> * The obsolete directApi option is all over the test code.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)