You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@falcon.apache.org by Paul Isaychuk <pi...@hortonworks.com> on 2014/12/15 21:00:01 UTC

Review Request 29059: [FALCON-948] Enabling late rerun tests

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29059/
-----------------------------------------------------------

Review request for Falcon.

Bugs: FALCON-948
https://issues.apache.org/jira/browse/FALCON-948

Repository: falcon-git

Description
-------

Enable FeedLateRerunTest and ProcessLateRerunTest. Some unfunctional fixed were made to make tests running, as well as some refactoring and clean up.

Diffs
-----

falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HadoopUtil.java 3cb4f94
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java 4f9bd9d
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java 95919ee
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java da38085
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java e1a4dd4
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java 488cf74

Diff: https://reviews.apache.org/r/29059/diff/

Testing
-------

ProcessLateRerunTest was tested locally, passed all times. FeedLateRerunTest fails on rerun validation.
As for me the reason can be an invalid test case. Because I don't see any references in doc to have replication reran after late arrival http://falcon.incubator.apache.org/EntitySpecification.html#Feed_Specification. For me it seems that only process which depends on feed, can be reran that way.
Anyway according to the requirement, we can enable these tests, open a bug for failing test class and then figure out necessary details.

Thanks,

Paul Isaychuk

Re: Review Request 29059: [FALCON-948] Enabling late rerun tests

Posted by Ruslan Ostafiychuk <ro...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29059/#review65622
-----------------------------------------------------------

Ship it!


Ship It!

- Ruslan Ostafiychuk


On Dec. 19, 2014, 10:33 a.m., Paul Isaychuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29059/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2014, 10:33 a.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-948
>     https://issues.apache.org/jira/browse/FALCON-948
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Enable FeedLateRerunTest and ProcessLateRerunTest. Some unfunctional fixed like cutting protocols from data paths, were made to make tests running, as well as some refactoring (replacing method to HadoopUtil).
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HadoopUtil.java 3cb4f94 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java 4f9bd9d 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java 95919ee 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java da38085 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java e1a4dd4 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java 488cf74 
> 
> Diff: https://reviews.apache.org/r/29059/diff/
> 
> 
> Testing
> -------
> 
> Now both tests pass
> 
> 
> Thanks,
> 
> Paul Isaychuk
> 
>

Re: Review Request 29059: [FALCON-948] Enabling late rerun tests

Posted by Paul Isaychuk <pi...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29059/
-----------------------------------------------------------

(Updated Dec. 19, 2014, 10:33 a.m.)


Review request for Falcon.


Changes
-------

marking a method as deprecated for further update


Bugs: FALCON-948
    https://issues.apache.org/jira/browse/FALCON-948


Repository: falcon-git


Description
-------

Enable FeedLateRerunTest and ProcessLateRerunTest. Some unfunctional fixed like cutting protocols from data paths, were made to make tests running, as well as some refactoring (replacing method to HadoopUtil).


Diffs (updated)
-----

  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HadoopUtil.java 3cb4f94 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java 4f9bd9d 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java 95919ee 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java da38085 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java e1a4dd4 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java 488cf74 

Diff: https://reviews.apache.org/r/29059/diff/


Testing
-------

Now both tests pass


Thanks,

Paul Isaychuk

Re: Review Request 29059: [FALCON-948] Enabling late rerun tests

Posted by PRAGYA MITTAL <mi...@gmail.com>.


> On Dec. 18, 2014, 8:48 a.m., PRAGYA MITTAL wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java, line 167
> > <https://reviews.apache.org/r/29059/diff/2/?file=794850#file794850line167>
> >
> >     Is cutProtocol function necessary here ?
> 
> PRAGYA MITTAL wrote:
>     +1 after review comments are addressed

+1.Understood the requirement.Good to go.


- PRAGYA


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29059/#review65472
-----------------------------------------------------------


On Dec. 17, 2014, 8:21 p.m., Paul Isaychuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29059/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2014, 8:21 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-948
>     https://issues.apache.org/jira/browse/FALCON-948
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Enable FeedLateRerunTest and ProcessLateRerunTest. Some unfunctional fixed like cutting protocols from data paths, were made to make tests running, as well as some refactoring (replacing method to HadoopUtil).
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HadoopUtil.java 3cb4f94 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java 4f9bd9d 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java 95919ee 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java da38085 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java e1a4dd4 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java 488cf74 
> 
> Diff: https://reviews.apache.org/r/29059/diff/
> 
> 
> Testing
> -------
> 
> Now both tests pass
> 
> 
> Thanks,
> 
> Paul Isaychuk
> 
>

Re: Review Request 29059: [FALCON-948] Enabling late rerun tests

Posted by PRAGYA MITTAL <mi...@gmail.com>.


> On Dec. 18, 2014, 8:48 a.m., PRAGYA MITTAL wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java, line 167
> > <https://reviews.apache.org/r/29059/diff/2/?file=794850#file794850line167>
> >
> >     Is cutProtocol function necessary here ?

+1 after review comments are addressed


- PRAGYA


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29059/#review65472
-----------------------------------------------------------


On Dec. 17, 2014, 8:21 p.m., Paul Isaychuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29059/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2014, 8:21 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-948
>     https://issues.apache.org/jira/browse/FALCON-948
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Enable FeedLateRerunTest and ProcessLateRerunTest. Some unfunctional fixed like cutting protocols from data paths, were made to make tests running, as well as some refactoring (replacing method to HadoopUtil).
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HadoopUtil.java 3cb4f94 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java 4f9bd9d 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java 95919ee 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java da38085 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java e1a4dd4 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java 488cf74 
> 
> Diff: https://reviews.apache.org/r/29059/diff/
> 
> 
> Testing
> -------
> 
> Now both tests pass
> 
> 
> Thanks,
> 
> Paul Isaychuk
> 
>

Re: Review Request 29059: [FALCON-948] Enabling late rerun tests

Posted by PRAGYA MITTAL <mi...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29059/#review65472
-----------------------------------------------------------



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java
<https://reviews.apache.org/r/29059/#comment108657>

    Is cutProtocol function necessary here ?


- PRAGYA MITTAL


On Dec. 17, 2014, 8:21 p.m., Paul Isaychuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29059/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2014, 8:21 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: FALCON-948
>     https://issues.apache.org/jira/browse/FALCON-948
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Enable FeedLateRerunTest and ProcessLateRerunTest. Some unfunctional fixed like cutting protocols from data paths, were made to make tests running, as well as some refactoring (replacing method to HadoopUtil).
> 
> 
> Diffs
> -----
> 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HadoopUtil.java 3cb4f94 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java 4f9bd9d 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java 95919ee 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java da38085 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java e1a4dd4 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java 488cf74 
> 
> Diff: https://reviews.apache.org/r/29059/diff/
> 
> 
> Testing
> -------
> 
> Now both tests pass
> 
> 
> Thanks,
> 
> Paul Isaychuk
> 
>

Re: Review Request 29059: [FALCON-948] Enabling late rerun tests

Posted by Paul Isaychuk <pi...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29059/
-----------------------------------------------------------

(Updated Dec. 17, 2014, 8:21 p.m.)


Review request for Falcon.


Bugs: FALCON-948
    https://issues.apache.org/jira/browse/FALCON-948


Repository: falcon-git


Description
-------

Enable FeedLateRerunTest and ProcessLateRerunTest. Some unfunctional fixed like cutting protocols from data paths, were made to make tests running, as well as some refactoring (replacing method to HadoopUtil).


Diffs
-----

  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/HadoopUtil.java 3cb4f94 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java 4f9bd9d 
  falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/OozieUtil.java 95919ee 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/FeedLateRerunTest.java da38085 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessInstanceKillsTest.java e1a4dd4 
  falcon-regression/merlin/src/test/java/org/apache/falcon/regression/ProcessLateRerunTest.java 488cf74 

Diff: https://reviews.apache.org/r/29059/diff/


Testing (updated)
-------

Now both tests pass


Thanks,

Paul Isaychuk

Re: Review Request 29059: [FALCON-948] Enabling late rerun tests

Posted by Paul Isaychuk <pi...@hortonworks.com>.

(Updated Dec. 17, 2014, 7:11 p.m.)

Review request for Falcon.

Changes
-------

adding few changes

Bugs: FALCON-948
https://issues.apache.org/jira/browse/FALCON-948

Repository: falcon-git

Description
-------

Enable FeedLateRerunTest and ProcessLateRerunTest. Some unfunctional fixed like cutting protocols from data paths, were made to make tests running, as well as some refactoring (replacing method to HadoopUtil).

Diffs (updated)
-----

Diff: https://reviews.apache.org/r/29059/diff/

Testing
-------

Thanks,

Paul Isaychuk

Re: Review Request 29059: [FALCON-948] Enabling late rerun tests

Posted by Paul Isaychuk <pi...@hortonworks.com>.

(Updated Dec. 15, 2014, 8:02 p.m.)

Review request for Falcon.

Bugs: FALCON-948
https://issues.apache.org/jira/browse/FALCON-948

Repository: falcon-git

Description (updated)
-------

Diffs
-----

Diff: https://reviews.apache.org/r/29059/diff/

Testing
-------

Thanks,

Paul Isaychuk