Re: [PR] KAFKA-15668: Adding Opentelmetry shadowed library (KIP-714) [kafka]

["xvrl (via GitHub)" <gi...@apache.org>]

xvrl commented on code in PR #14618:
URL: https://github.com/apache/kafka/pull/14618#discussion_r1378978236


##########
build.gradle:
##########
@@ -1379,11 +1392,40 @@ project(':clients') {
     }
   }
 
-  jar {
+  shadowJar {
     dependsOn createVersionFile
+    // archiveClassifier defines the classifier for the shadow jar, the default is 'all'.
+    // We don't want to use the default classifier because it will cause the shadow jar to
+    // overwrite the original jar. We also don't want to use the 'shadow' classifier because
+    // it will cause the shadow jar to be named kafka-clients-shadow.jar. We want to use the
+    // same name as the original jar, kafka-clients.jar.
+    archiveClassifier = null
+    // KIP-714: move shaded dependencies to a shaded location
+    relocate('io.opentelemetry.proto', 'org.apache.kafka.shaded.io.opentelemetry.proto')
+    relocate('com.google.protobuf', 'org.apache.kafka.shaded.com.google.protobuf')
+
+    // dependencies exclusion from the final jar.

Review Comment:
   ```suggestion
       // dependencies excluded from the final jar, since they are declared as runtime dependencies
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org