[GitHub] [spark] wangyum commented on a change in pull request #23899: [SPARK-26969][spark-thriftserver] Bigdecimal values shall be converted to HiveDecimal type for succesful processing of query using ODBC interface

[GitBox <gi...@apache.org>]

wangyum commented on a change in pull request #23899: [SPARK-26969][spark-thriftserver] Bigdecimal values shall be converted to HiveDecimal type for succesful processing of query using ODBC interface
URL: https://github.com/apache/spark/pull/23899#discussion_r311926819
 
 

 ##########
 File path: sql/hive-thriftserver/v1.2.1/src/main/java/org/apache/hive/service/cli/ColumnValue.java
 ##########
 @@ -195,7 +195,7 @@ public static TColumnValue toTColumnValue(Type type, Object value) {
     case INTERVAL_DAY_TIME_TYPE:
       return stringValue((HiveIntervalDayTime) value);
     case DECIMAL_TYPE:
-      return stringValue(((HiveDecimal)value));
+      return getDecimalType(value);
 
 Review comment:
   ```return stringValue(((BigDecimal)value).toPlainString());```?
   
   
   https://github.com/apache/hive/blob/release-2.3.5-rc0/storage-api/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java#L725

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org