[GitHub] [spark] dongjoon-hyun commented on a change in pull request #34147: [SPARK-36896][PYTHON] Return boolean for `dropTempView` and `dropGlobalTempView`

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #34147:
URL: https://github.com/apache/spark/pull/34147#discussion_r719022049



##########
File path: python/pyspark/sql/catalog.py
##########
@@ -50,7 +50,7 @@ def currentDatabase(self):
     @since(2.0)
     def setCurrentDatabase(self, dbName):
         """Sets the current default database in this session."""
-        return self._jcatalog.setCurrentDatabase(dbName)
+        self._jcatalog.setCurrentDatabase(dbName)

Review comment:
       Shall we mention `setCurrentDatabase` together?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org