You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "helifu (Code Review)" <ge...@cloudera.org> on 2019/11/01 08:43:36 UTC

[kudu-CR] KUDU-2986 p2: adjust the 'live row count' metric in master's Web UI

Hello Alexey Serbin, Yifan Zhang, Kudu Jenkins, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14601

to look at the new patch set (#2).

Change subject: KUDU-2986 p2: adjust the 'live_row_count' metric in master's Web UI
......................................................................

KUDU-2986 p2: adjust the 'live_row_count' metric in master's Web UI

The 'live_row_count' metric should be N/A(invalid) in master's Web UI
while there is any tablet which doesn't support live row count.

http://master:8051/metrics?ids=5448c0a8658f467ea373d9044d567011

[
    {
        "type": "table",
        "id": "5448c0a8658f467ea373d9044d567011",
        "attributes": {
            "table_name": "testtable"
        },
        "metrics": [
            {
                "name": "live_row_count",
                "value": "N/A"
            },
            {
                "name": "on_disk_size",
                "value": 8417243
            }
        ]
    }
]

Change-Id: I4c7ac5ca7e8ce9dcc37035a7bc46ca69060d6533
---
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master-test.cc
M src/kudu/master/master_path_handlers.cc
M src/kudu/master/table_metrics.cc
M src/kudu/master/table_metrics.h
6 files changed, 103 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/14601/2
-- 
To view, visit http://gerrit.cloudera.org:8080/14601
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4c7ac5ca7e8ce9dcc37035a7bc46ca69060d6533
Gerrit-Change-Number: 14601
Gerrit-PatchSet: 2
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: helifu <hz...@corp.netease.com>