[GitHub] [trafficserver] traeak commented on a diff in pull request #8918: uri_signing/parse: check for null iss when kid == NULL

[GitBox <gi...@apache.org>]

traeak commented on code in PR #8918:
URL: https://github.com/apache/trafficserver/pull/8918#discussion_r902530399


##########
plugins/experimental/uri_signing/parse.c:
##########
@@ -222,6 +222,10 @@ validate_jws(cjose_jws_t *jws, struct config *cfg, const char *uri, size_t uri_c
     }
     TimerDebug("checking crypto signature for jwt");
   } else {
+    if (!jwt->iss) {

Review Comment:
   You could be correct.  This path was core dumping with the autest after applying some internal patches.  I can dig a bit to see if I can move the check up higher.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org