[GitHub] [helix] narendly commented on a change in pull request #624: Stabilize 5 unstable tests

[GitBox <gi...@apache.org>]

narendly commented on a change in pull request #624: Stabilize 5 unstable tests
URL: https://github.com/apache/helix/pull/624#discussion_r350324191
 
 

 ##########
 File path: helix-core/src/test/java/org/apache/helix/integration/task/TestStopWorkflow.java
 ##########
 @@ -203,13 +202,20 @@ public void testResumeTaskForQuota() throws InterruptedException {
 
     _driver.start(workflowBuilder_1.build());
 
-    Thread.sleep(2000L); // Sleep until each task really is in progress
+    // Check the jobs are in progress. Each job has one task.
+    for (int i = 0; i < 30; i++) {
+      _driver.pollForJobState(workflowName_1, workflowName_1 + "_JOB" + i, TaskState.IN_PROGRESS);
+    }
 
 Review comment:
   Nit: Could a job be in progress but its task not in RUNINNG state? Do you need to check for the task state?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org