[GitHub] [hive] johan-g commented on a change in pull request #1870: HIVE-24637 make Tez progress log interval configurable

[GitBox <gi...@apache.org>]

johan-g commented on a change in pull request #1870:
URL: https://github.com/apache/hive/pull/1870#discussion_r562102132



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/RenderStrategy.java
##########
@@ -39,7 +40,16 @@
   }
 
   private abstract static class BaseUpdateFunction implements UpdateFunction {
-    private static final int PRINT_INTERVAL = 3000;
+    private static final long PRINT_INTERVAL;
+
+    static {

Review comment:
       Thanks for the feedback @kgyrtkirk, I've added a `getHiveConf` function to `TezJobMonitor` and move this logic to the constructor of `BaseUpdateFunction`. I guess another approach could be to get `HiveConf` from `SessionState` which is used in the constructor for `perfLogger` already, but grepping for other cases of this approach it doesn't seem to common.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org