You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/11/11 16:43:06 UTC
[GitHub] [flink] mxm commented on a change in pull request #10153: [FLINK-14709] Allow outputting elements in user defined close method,…
mxm commented on a change in pull request #10153: [FLINK-14709] Allow outputting elements in user defined close method,…
URL: https://github.com/apache/flink/pull/10153#discussion_r344795540
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/operators/BatchTask.java
##########
@@ -509,11 +509,14 @@ protected void run() throws Exception {
stubOpen = false;
}
- this.output.close();
-
// close all chained tasks letting them report failure
BatchTask.closeChainedTasks(this.chainedTasks, this);
+
+ // close the output collector
+ this.output.close();
+
}
+
Review comment:
Looks like an unrelated change. Please revert.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services