You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by mice xia <mi...@tcloudcomputing.com> on 2012/08/02 04:07:36 UTC

Review Request: CS-15814 Description of global configuration 'encode.api.response' is incorrect

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6279/
-----------------------------------------------------------

Review request for cloudstack and Alena Prokharchyk.


Description
-------

changes:
change xml response default encoding as UTF-8
change description of encode.api.response


This addresses bug CS-15814.


Diffs
-----

  server/src/com/cloud/api/response/ApiResponseSerializer.java 83e4e6e 
  server/src/com/cloud/configuration/Config.java 6c0af1b 

Diff: https://reviews.apache.org/r/6279/diff/


Testing
-------

verified


Thanks,

mice xia


Re: Review Request: CS-15814 Description of global configuration 'encode.api.response' is incorrect

Posted by mice xia <mi...@tcloudcomputing.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6279/
-----------------------------------------------------------

(Updated Aug. 2, 2012, 2:18 p.m.)


Review request for cloudstack, Nitin Mehta and Alena Prokharchyk.


Changes
-------

add db upgrade sql in schema-303to40.sql


Description
-------

changes:
change xml response default encoding as UTF-8
change description of encode.api.response


This addresses bug CS-15814.


Diffs (updated)
-----

  server/src/com/cloud/api/response/ApiResponseSerializer.java 83e4e6e 
  server/src/com/cloud/configuration/Config.java b77537e 
  setup/db/db/schema-303to40.sql 4ce8e65 

Diff: https://reviews.apache.org/r/6279/diff/


Testing
-------

verified


Thanks,

mice xia


Re: Review Request: CS-15814 Description of global configuration 'encode.api.response' is incorrect

Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6279/#review9740
-----------------------------------------------------------


You also need to put the global config change in the schema-currentVersion#tofutureVersion# (example schema-301to302.sql) for upgrade purposes.

- Nitin Mehta


On Aug. 2, 2012, 2:07 a.m., mice xia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6279/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2012, 2:07 a.m.)
> 
> 
> Review request for cloudstack and Alena Prokharchyk.
> 
> 
> Description
> -------
> 
> changes:
> change xml response default encoding as UTF-8
> change description of encode.api.response
> 
> 
> This addresses bug CS-15814.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/api/response/ApiResponseSerializer.java 83e4e6e 
>   server/src/com/cloud/configuration/Config.java 6c0af1b 
> 
> Diff: https://reviews.apache.org/r/6279/diff/
> 
> 
> Testing
> -------
> 
> verified
> 
> 
> Thanks,
> 
> mice xia
> 
>