[GitHub] [airflow] potiuk commented on a change in pull request #12440: Cope with '%' in password when waiting for migrations

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #12440:
URL: https://github.com/apache/airflow/pull/12440#discussion_r525974640



##########
File path: chart/templates/_helpers.yaml
##########
@@ -380,7 +380,7 @@ server_tls_key_file = /etc/pgbouncer/server.key
         directory = os.path.join(package_dir, 'migrations')
         config = Config(os.path.join(package_dir, 'alembic.ini'))
         config.set_main_option('script_location', directory)
-        config.set_main_option('sqlalchemy.url', settings.SQL_ALCHEMY_CONN)
+        config.set_main_option('sqlalchemy.url', settings.SQL_ALCHEMY_CONN.replace('%', '%%'))

Review comment:
       Isn't that a problem of the wrong URL specified?
   
   For the SQL alchemy connection should be URL-encoded in the first place. This is true for the individual parameters of the query but also for user and password. So I think your problem is that in your original URL you should us %25 where you have '%'  and not replace % with %%.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org