You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/03/27 22:55:02 UTC
[GitHub] [maven-surefire] Tibor17 opened a new pull request #502: [SUREFIRE-1432] trimStackTrace = false by default
Tibor17 opened a new pull request #502:
URL: https://github.com/apache/maven-surefire/pull/502
Backporting the improvement SUREFIRE-1432 (8a6b33453d3114e755ad9f0776bd8f5ca7bf3bc0) from the branch origin/release/3.0.0-M6 to origin/master.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean install`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 merged pull request #502: [SUREFIRE-1432] trimStackTrace = false by default
Posted by GitBox <gi...@apache.org>.
Tibor17 merged pull request #502:
URL: https://github.com/apache/maven-surefire/pull/502
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #502: [SUREFIRE-1432] trimStackTrace = false by default
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #502:
URL: https://github.com/apache/maven-surefire/pull/502#issuecomment-1081284797
@slawekjaranowski
IMHO, he could not find the business logic.
We use `SmartStackTraceParser` everywhere except the JUnit3 provider.
Currently the logic is located in the class `EventChannelEncoder.StackTrace` and the event sticks to `boolean trimStackTraces` which comes from MOJO config.
Probably he means `SmartStackTraceParser#writeTrimmedTraceToString()` by DefaultStackTraceImpl, and `SmartStackTraceParser#writeTraceToString()` by SmartStackTraceImpl.
I think the historycal code had two classes and DefaultXXX but I hardly remember. Maybe the history Git shows more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #502: [SUREFIRE-1432] trimStackTrace = false by default
Posted by GitBox <gi...@apache.org>.
Tibor17 edited a comment on pull request #502:
URL: https://github.com/apache/maven-surefire/pull/502#issuecomment-1081284797
@slawekjaranowski
I think I took over the description by some user.
IMHO, the user could not find the business logic. Now we use `SmartStackTraceParser` everywhere except the JUnit3 provider. Currently the logic is located in the class `EventChannelEncoder.StackTrace` and the event sticks to `boolean trimStackTraces` which comes from MOJO config.
Probably he means `SmartStackTraceParser#writeTraceToString()` by DefaultStackTraceImpl, and `SmartStackTraceParser#writeTrimmedTraceToString()` by SmartStackTraceImpl.
I think the historycal code had two classes and DefaultXXX but I hardly remember. Maybe the history Git shows more.
We can rewrite the description because it does not match the #203 from the contributor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #502: [SUREFIRE-1432] trimStackTrace = false by default
Posted by GitBox <gi...@apache.org>.
Tibor17 edited a comment on pull request #502:
URL: https://github.com/apache/maven-surefire/pull/502#issuecomment-1081284797
@slawekjaranowski
I think I took over the description by some user.
Now we use `SmartStackTraceParser` everywhere except the JUnit3 provider. Currently the logic is located in the class `EventChannelEncoder.StackTrace` and the event sticks to `boolean trimStackTraces` which comes from MOJO config.
Probably `SmartStackTraceParser#writeTraceToString()` is DefaultStackTraceImpl, and `SmartStackTraceParser#writeTrimmedTraceToString()` is SmartStackTraceImpl.
I think the historycal code had two classes and DefaultXXX but I hardly remember. Maybe the history Git shows more.
We can rewrite the description because it does not match the #203 from the contributor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #502: [SUREFIRE-1432] trimStackTrace = false by default
Posted by GitBox <gi...@apache.org>.
Tibor17 edited a comment on pull request #502:
URL: https://github.com/apache/maven-surefire/pull/502#issuecomment-1081284797
@slawekjaranowski
IMHO, he could not find the business logic.
We use `SmartStackTraceParser` everywhere except the JUnit3 provider.
Currently the logic is located in the class `EventChannelEncoder.StackTrace` and the event sticks to `boolean trimStackTraces` which comes from MOJO config.
Probably he means `SmartStackTraceParser#writeTraceToString()` by DefaultStackTraceImpl, and `SmartStackTraceParser#writeTrimmedTraceToString()` by SmartStackTraceImpl.
I think the historycal code had two classes and DefaultXXX but I hardly remember. Maybe the history Git shows more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #502: [SUREFIRE-1432] trimStackTrace = false by default
Posted by GitBox <gi...@apache.org>.
Tibor17 edited a comment on pull request #502:
URL: https://github.com/apache/maven-surefire/pull/502#issuecomment-1081284797
@slawekjaranowski
I think I took over the description by some user.
Now we use `SmartStackTraceParser` everywhere except the JUnit3 provider. Currently, the logic is located in the class `EventChannelEncoder.StackTrace` and the event sticks to `boolean trimStackTraces` which comes from MOJO config.
Probably `SmartStackTraceParser#writeTraceToString()` is DefaultStackTraceImpl, and `SmartStackTraceParser#writeTrimmedTraceToString()` is SmartStackTraceImpl.
I think the historycal code had two classes and DefaultXXX but I hardly remember. Maybe the Git history shows more.
We can rewrite the description because it does not match the #203 from the contributor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #502: [SUREFIRE-1432] trimStackTrace = false by default
Posted by GitBox <gi...@apache.org>.
Tibor17 edited a comment on pull request #502:
URL: https://github.com/apache/maven-surefire/pull/502#issuecomment-1081315961
@slawekjaranowski
I have cleaned up the [release backlog](https://issues.apache.org/jira/issues/?jql=project%20%3D%20SUREFIRE%20AND%20fixVersion%20%3D%203.0.0-M6%20ORDER%20BY%20status%20ASC) and there is only this issue with the status - reopened. The rest of the tickets are closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #502: [SUREFIRE-1432] trimStackTrace = false by default
Posted by GitBox <gi...@apache.org>.
Tibor17 commented on pull request #502:
URL: https://github.com/apache/maven-surefire/pull/502#issuecomment-1081315961
@slawekjaranowski
I have cleaned up the [release backlog](https://issues.apache.org/jira/issues/?jql=project%20%3D%20SUREFIRE%20AND%20fixVersion%20%3D%203.0.0-M6%20ORDER%20BY%20status%20ASC) and there is only this issue in the status - reopened. The rest of the tickets are closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #502: [SUREFIRE-1432] trimStackTrace = false by default
Posted by GitBox <gi...@apache.org>.
Tibor17 edited a comment on pull request #502:
URL: https://github.com/apache/maven-surefire/pull/502#issuecomment-1081284797
@slawekjaranowski
I think I took over the description by some user.
IMHO, the user could not find the business logic. Now we use `SmartStackTraceParser` everywhere except the JUnit3 provider. Currently the logic is located in the class `EventChannelEncoder.StackTrace` and the event sticks to `boolean trimStackTraces` which comes from MOJO config.
Probably he means `SmartStackTraceParser#writeTraceToString()` by DefaultStackTraceImpl, and `SmartStackTraceParser#writeTrimmedTraceToString()` by SmartStackTraceImpl.
I think the historycal code had two classes and DefaultXXX but I hardly remember. Maybe the history Git shows more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org