You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2015/08/10 20:10:20 UTC
svn commit: r1695144 - in
/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile:
PMGClass.java Signature.java SimpleElementValue.java SourceFile.java
Author: sebb
Date: Mon Aug 10 18:10:20 2015
New Revision: 1695144
URL: http://svn.apache.org/r1695144
Log:
TODOs
Modified:
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/PMGClass.java
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Signature.java
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/SimpleElementValue.java
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/SourceFile.java
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/PMGClass.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/PMGClass.java?rev=1695144&r1=1695143&r2=1695144&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/PMGClass.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/PMGClass.java Mon Aug 10 18:10:20 2015
@@ -34,12 +34,12 @@ import org.apache.commons.bcel6.Constant
public final class PMGClass extends Attribute {
private static final long serialVersionUID = -7075964153234211509L;
- private int pmg_class_index, pmg_index;
+ private int pmg_class_index, pmg_index; // TODO could be final (setter unused)
/**
* Initialize from another object. Note that both objects use the same
- * references (shallow copy). Use clone() for a physical copy.
+ * references (shallow copy). Use copy() for a physical copy.
*/
public PMGClass(PMGClass c) {
this(c.getNameIndex(), c.getLength(), c.getPMGIndex(), c.getPMGClassIndex(), c
@@ -114,7 +114,7 @@ public final class PMGClass extends Attr
/**
* @param pmg_class_index
*/
- public final void setPMGClassIndex( int pmg_class_index ) {
+ public final void setPMGClassIndex( int pmg_class_index ) { // TODO unused
this.pmg_class_index = pmg_class_index;
}
@@ -130,7 +130,7 @@ public final class PMGClass extends Attr
/**
* @param pmg_index
*/
- public final void setPMGIndex( int pmg_index ) {
+ public final void setPMGIndex( int pmg_index ) { // TODO unused
this.pmg_index = pmg_index;
}
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Signature.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Signature.java?rev=1695144&r1=1695143&r2=1695144&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Signature.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Signature.java Mon Aug 10 18:10:20 2015
@@ -35,7 +35,7 @@ import org.apache.commons.bcel6.Constant
public final class Signature extends Attribute {
private static final long serialVersionUID = 5808807822688827177L;
- private int signature_index;
+ private int signature_index; // TODO could be final (setter unused)
/**
@@ -111,7 +111,7 @@ public final class Signature extends Att
/**
* @param signature_index the index info the constant pool of this signature
*/
- public final void setSignatureIndex( int signature_index ) {
+ public final void setSignatureIndex( int signature_index ) { // TODO unused
this.signature_index = signature_index;
}
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/SimpleElementValue.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/SimpleElementValue.java?rev=1695144&r1=1695143&r2=1695144&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/SimpleElementValue.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/SimpleElementValue.java Mon Aug 10 18:10:20 2015
@@ -27,7 +27,7 @@ import org.apache.commons.bcel6.Constant
*/
public class SimpleElementValue extends ElementValue
{
- private int index;
+ private int index; // TODO could be final (setter unused)
public SimpleElementValue(int type, int index, ConstantPool cpool)
{
@@ -43,7 +43,7 @@ public class SimpleElementValue extends
return index;
}
- public void setIndex(int index)
+ public void setIndex(int index) // TODO unused
{
this.index = index;
}
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/SourceFile.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/SourceFile.java?rev=1695144&r1=1695143&r2=1695144&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/SourceFile.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/SourceFile.java Mon Aug 10 18:10:20 2015
@@ -36,7 +36,7 @@ import org.apache.commons.bcel6.Constant
public final class SourceFile extends Attribute {
private static final long serialVersionUID = -804226255663222912L;
- private int sourcefile_index;
+ private int sourcefile_index; // TODO could be final (setter unused)
/**
@@ -118,7 +118,7 @@ public final class SourceFile extends At
/**
* @param sourcefile_index
*/
- public final void setSourceFileIndex( int sourcefile_index ) {
+ public final void setSourceFileIndex( int sourcefile_index ) { // TODO unused
this.sourcefile_index = sourcefile_index;
}