You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/11/03 14:06:45 UTC

[GitHub] [calcite] vlsi commented on pull request #2236: [CALCITE-3913] Test correctness using formal verification (Qi Zhou)

vlsi commented on pull request #2236:
URL: https://github.com/apache/calcite/pull/2236#issuecomment-720787197


   @qizhou92 , this looks nice.
   Have you seen `RexFuzzer`, `RexProgramFuzzyTest`, `org.apache.calcite.rex.RexSimplify#verify` ?
   
   I wonder if `z3` verifications could be integrated to `RexSimplify#verify`. Of course, it would be limited to `int` or something, but it still might be valuable.
   
   An alternative option is to add a dedicated case to `RexProgramFuzzyTest` which would generate `int-only` randomized expressions (e.g. via `RexFuzzer`), and verify if `RexSimplfy` does not corrupt them.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org