You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/07/25 16:59:25 UTC
[GitHub] [orc] dependabot[bot] opened a new pull request #769: Bump jmh.version from 1.20 to 1.32 in /java
dependabot[bot] opened a new pull request #769:
URL: https://github.com/apache/orc/pull/769
Bumps `jmh.version` from 1.20 to 1.32.
Updates `jmh-core` from 1.20 to 1.32
Updates `jmh-generator-annprocess` from 1.20 to 1.32
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] kbendick edited a comment on pull request #769: Bump jmh.version from 1.20 to 1.32 in /java
Posted by GitBox <gi...@apache.org>.
kbendick edited a comment on pull request #769:
URL: https://github.com/apache/orc/pull/769#issuecomment-886418788
> In this PR, we are clearly see `jmh` 1.20 to 1.32 is breaking because there are big gap. We have two options
>
> 1. Pin the version
> 2. Make an official JIRA for this upgrade.
>
> cc @wgtmac , @pgaref , @williamhyun
In the Apache Iceberg repo, we [pin JMH to version 1.21](https://github.com/apache/iceberg/blob/0b53e70d813f6acfb3198567781d3b3ef921d6d8/build.gradle#L118), which is very close to the existing 1.20.
I have been somewhat taking care of the JMH tests over there / have most recently worked on them.
For us, the upgrade is a larger deal because we use a [specific JMH gradle plugin](https://github.com/melix/jmh-gradle-plugin) which would require a newer version of gradle to be able to upgrade the dependency. I would personally recommend pinning the version in the short term, and then making a JIRA for upgrading.
As I've become somewhat more familiar with JMH testing from working with the Iceberg JMH tests, I'd be happy to take the JIRA for upgrading JMH to 1.32 assuming we don't use any plugins which would involve a much larger refactor (I don't think we do). 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] pgaref closed pull request #769: Bump jmh.version from 1.20 to 1.32 in /java
Posted by GitBox <gi...@apache.org>.
pgaref closed pull request #769:
URL: https://github.com/apache/orc/pull/769
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #769: Bump jmh.version from 1.20 to 1.32 in /java
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #769:
URL: https://github.com/apache/orc/pull/769#issuecomment-886444158
I made a PR (#777) to pin `jmh` and filed ORC-870 for upgrading jmh officially.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] kbendick edited a comment on pull request #769: Bump jmh.version from 1.20 to 1.32 in /java
Posted by GitBox <gi...@apache.org>.
kbendick edited a comment on pull request #769:
URL: https://github.com/apache/orc/pull/769#issuecomment-886418788
> In this PR, we are clearly see `jmh` 1.20 to 1.32 is breaking because there are big gap. We have two options
>
> 1. Pin the version
> 2. Make an official JIRA for this upgrade.
>
> cc @wgtmac , @pgaref , @williamhyun
In the Apache Iceberg repo, we [pin JMH to version 1.21](https://github.com/apache/iceberg/blob/0b53e70d813f6acfb3198567781d3b3ef921d6d8/build.gradle#L118), which is very close to the existing 1.20.
I have been somewhat taking care of the JMH tests over there / have most recently worked on them.
For us, the upgrade is a larger deal because we use a [specific JMH gradle plugin](https://github.com/melix/jmh-gradle-plugin) which would require a newer version of gradle to upgrade to. I would personally recommend pinning the version in the short term, and then making a JIRA for upgrading.
As I've become somewhat more familiar with JMH testing from working with the Iceberg JMH tests, I'd be happy to take the JIRA for upgrading JMH to 1.32 assuming we don't use any plugins which would involve a much larger refactor (I don't think we do). 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] kbendick commented on pull request #769: Bump jmh.version from 1.20 to 1.32 in /java
Posted by GitBox <gi...@apache.org>.
kbendick commented on pull request #769:
URL: https://github.com/apache/orc/pull/769#issuecomment-886418788
> In this PR, we are clearly see `jmh` 1.20 to 1.32 is breaking because there are big gap. We have two options
>
> 1. Pin the version
> 2. Make an official JIRA for this upgrade.
>
> cc @wgtmac , @pgaref , @williamhyun
In the Apache Iceberg repo, we [pin JMH to version 1.21](https://github.com/apache/iceberg/blob/0b53e70d813f6acfb3198567781d3b3ef921d6d8/build.gradle#L118), which is very close to the existing 1.20.
I have been somewhat taking care of the JMH tests over there / most recently worked on them.
For us, the upgrade is a larger deal because we use a [specific JMH gradle plugin](https://github.com/melix/jmh-gradle-plugin) which would require a newer version of gradle to upgrade to. I would personally recommend pinning the version in the short term, and then making a JIRA for upgrading.
As I've become somewhat more familiar with JMH testing from working with the Iceberg JMH tests, I'd be happy to take the JIRA for upgrading JMH to 1.32 assuming we don't use any plugins which would involve a much larger refactor (I don't think we do). 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #769: Bump jmh.version from 1.20 to 1.32 in /java
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #769:
URL: https://github.com/apache/orc/pull/769#issuecomment-886436006
Thank you for the sharing, @kbendick ! I'll pin it in Apache ORC too. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dependabot[bot] commented on pull request #769: Bump jmh.version from 1.20 to 1.32 in /java
Posted by GitBox <gi...@apache.org>.
dependabot[bot] commented on pull request #769:
URL: https://github.com/apache/orc/pull/769#issuecomment-886637766
OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file.
If you change your mind, just re-open this PR and I'll resolve any conflicts on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org