You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/02/27 12:38:17 UTC
[GitHub] [hive] aasha opened a new pull request #927: Hive 22926
aasha opened a new pull request #927: Hive 22926
URL: https://github.com/apache/hive/pull/927
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] anishek commented on a change in pull request #927: Hive
22926 Schedule Repl Dump Task using Hive scheduler
Posted by GitBox <gi...@apache.org>.
anishek commented on a change in pull request #927: Hive 22926 Schedule Repl Dump Task using Hive scheduler
URL: https://github.com/apache/hive/pull/927#discussion_r386242814
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpWork.java
##########
@@ -32,32 +32,25 @@
final ReplScope replScope;
final ReplScope oldReplScope;
final String dbNameOrPattern, astRepresentationForErrorMsg, resultTempPath;
- final Long eventFrom;
Long eventTo;
Review comment:
we dont need this at all now ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] anishek commented on a change in pull request #927: Hive
22926 Schedule Repl Dump Task using Hive scheduler
Posted by GitBox <gi...@apache.org>.
anishek commented on a change in pull request #927: Hive 22926 Schedule Repl Dump Task using Hive scheduler
URL: https://github.com/apache/hive/pull/927#discussion_r386242894
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpWork.java
##########
@@ -32,32 +32,25 @@
final ReplScope replScope;
final ReplScope oldReplScope;
final String dbNameOrPattern, astRepresentationForErrorMsg, resultTempPath;
- final Long eventFrom;
Long eventTo;
- private Integer maxEventLimit;
+ Long eventFrom;
Review comment:
why not private ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org