You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by bu...@apache.org on 2006/09/13 22:07:27 UTC

DO NOT REPLY [Bug 40502] New: - SyslogAppender assumes all lines start with tab

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=40502>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40502

           Summary: SyslogAppender assumes all lines start with tab
           Product: Log4j
           Version: 1.2
          Platform: Other
        OS/Version: other
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Appender
        AssignedTo: log4j-dev@logging.apache.org
        ReportedBy: iwreilly@yahoo.com


The SyslogAppender assumes each line of output starts with a tab and replaces 
it with spaces.  If the line doesn't start with a tab, the first character of 
the line is lost.  If the line is empty, the appender will get an exception.

The patch to fix this problem is:

*** SyslogAppender.java.orig	Wed Sep 13 15:53:09 2006
--- SyslogAppender.java	Wed Sep 13 15:53:05 2006
***************
*** 260,266 ****
          if(len > 0) {
            sqw.write(s[0]);
            for(int i = 1; i < len; i++) {
!             sqw.write(TAB+s[i].substring(1));
            }
          }
        }
--- 260,274 ----
          if(len > 0) {
            sqw.write(s[0]);
            for(int i = 1; i < len; i++) {
!             if (s[i].length() > 0) {
!               if (s[i].charAt(0) == '\t') {
!                 sqw.write(TAB+s[i].substring(1));
!               } else {
!                 sqw.write(TAB+s[i]);
!               }
!             } else {
!               sqw.write(s[i]);
!             }
            }
          }
        }

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


DO NOT REPLY [Bug 40502] - SyslogAppender assumes all lines start with tab

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=40502>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40502


kay.abendroth@raxion.net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kay.abendroth@raxion.net
             Status|NEW                         |NEEDINFO




------- Additional Comments From kay.abendroth@raxion.net  2006-11-12 11:04 -------
Do you have this problem in 1.2.14 also?


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


DO NOT REPLY [Bug 40502] - SyslogAppender assumes all lines start with tab

Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=40502>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40502


carnold@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |RESOLVED
         Resolution|                            |FIXED




------- Additional Comments From carnold@apache.org  2007-02-21 15:40 -------
Bug is in 1.2.14, SyslogAppenderTest.testBadTabbing will throw an exception without code fix.

Committed against 1.2 branch in rev 510307.

Corresponding code in trunk has been commented out earlier.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org