You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/03 16:34:39 UTC
[GitHub] [skywalking-nodejs] tom-pytel opened a new pull request #7: Node 10 AsyncLocalStorage
tom-pytel opened a new pull request #7:
URL: https://github.com/apache/skywalking-nodejs/pull/7
For project I am working on Node 10 support is a requirement so I had to do this class to replicate AsyncLocalStorage functionality, but it is only used if AsyncLocalStorage does not exist in async_hooks. Otherwise SW would error out under Node 10.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] kezhenxu94 commented on pull request #7: Node 10 AsyncLocalStorage and Plugin loader
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #7:
URL: https://github.com/apache/skywalking-nodejs/pull/7#issuecomment-738471813
I added Node 10 to the test matrix to verify this works
> The commits will be squashed when merging and you are the only author of this pr
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] kezhenxu94 merged pull request #7: Node 10 AsyncLocalStorage and Plugin loader
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #7:
URL: https://github.com/apache/skywalking-nodejs/pull/7
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-nodejs] kezhenxu94 commented on pull request #7: Node 10 AsyncLocalStorage and Plugin loader
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #7:
URL: https://github.com/apache/skywalking-nodejs/pull/7#issuecomment-738537525
I finally realized that the tests are running inside the docker, so the matrix doesn't make much sense, I'll merge this first and open another PR to set up tests under different Node versions
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org