You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "squakez (via GitHub)" <gi...@apache.org> on 2025/10/17 08:47:28 UTC

[PR] fix(ci): JDK 25 compilation failure [camel]

squakez opened a new pull request, #19607:
URL: https://github.com/apache/camel/pull/19607

   This is due to the fact that those component main dependencies public API are leaking a @NotNull annotation which is parsed ad compilation time. JDK25 is not lenient and reports this as a compilation error
   
   NOTE: I am not liking that much to include those provided dependencies, but I don't see any other alternative.
   
   # Description
   
   <!--
   - Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   -->
   
   # Target
   
   - [ ] I checked that the commit is targeting the correct branch (Camel 4 uses the `main` branch)
   
   # Tracking
   - [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
   
   <!--
   # *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
   -->
   
   # Apache Camel coding standards and style
   
   - [ ] I checked that each commit in the pull request has a meaningful subject line and body.
   
   <!--
   If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
   -->
   
   - [ ] I have run `mvn clean install -DskipTests` locally from root folder and I have committed all auto-generated changes.
   
   <!--
   You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`.
   
   You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
   -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(ci): JDK 25 compilation failure [camel]

Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #19607:
URL: https://github.com/apache/camel/pull/19607#issuecomment-3414530219

   Also opened in AWS XRay: https://github.com/aws/aws-xray-sdk-java/issues/441


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(ci): JDK 25 compilation failure [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19607:
URL: https://github.com/apache/camel/pull/19607#issuecomment-3414483486

   :star2: Thank you for your contribution to the Apache Camel project! :star2: 
   
   :robot: CI automation will test this PR automatically.
   
   :camel: Apache Camel Committers, please review the following items:
   
   * First-time contributors **require MANUAL approval** for the GitHub Actions to run
   
   * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
   
   * You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
   
   * Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary. 
   
   * :warning: Be careful when sharing logs. Review their contents before sharing them publicly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(ci): JDK 25 compilation failure [camel]

Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on code in PR #19607:
URL: https://github.com/apache/camel/pull/19607#discussion_r2438912790


##########
components/camel-ai/camel-milvus/pom.xml:
##########
@@ -103,6 +103,14 @@
             </exclusions>
         </dependency>
 
+        <!-- Required as the Milvus API is leaking a @NonNull annotation -->
+        <dependency>
+            <groupId>org.projectlombok</groupId>
+            <artifactId>lombok</artifactId>
+            <version>1.18.30</version>

Review Comment:
   I'd also leave a note that it is here only as a temporary fix for being leaked by Milvus itself.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(ci): JDK 25 compilation failure [camel]

Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #19607:
URL: https://github.com/apache/camel/pull/19607#issuecomment-3414526849

   > Yes, I'm already reporting these issues upstream (see [milvus-io/milvus-sdk-java#1651](https://github.com/milvus-io/milvus-sdk-java/issues/1651)). I'm adding the versions in the parent then.
   
   Ah, you beat me to it! I was going to open a ticket too ... thanks for reporting!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(ci): JDK 25 compilation failure [camel]

Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #19607:
URL: https://github.com/apache/camel/pull/19607#issuecomment-3414515785

   Yes, I'm already reporting these issues upstream (see https://github.com/milvus-io/milvus-sdk-java/issues/1651). I'm adding the versions in the parent then.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(ci): JDK 25 compilation failure [camel]

Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd commented on code in PR #19607:
URL: https://github.com/apache/camel/pull/19607#discussion_r2438909008


##########
components/camel-aws/camel-aws-xray/pom.xml:
##########
@@ -88,6 +88,13 @@
             <artifactId>aws-xray-recorder-sdk-apache-http</artifactId>
         </dependency>
 
+        <!-- Required as the aws-xray-recorder-sdk-core API is leaking a @NonNull annotation -->
+        <dependency>
+            <groupId>org.checkerframework</groupId>
+            <artifactId>checker</artifactId>
+            <version>3.51.1</version>

Review Comment:
   Same



##########
components/camel-ai/camel-milvus/pom.xml:
##########
@@ -103,6 +103,14 @@
             </exclusions>
         </dependency>
 
+        <!-- Required as the Milvus API is leaking a @NonNull annotation -->
+        <dependency>
+            <groupId>org.projectlombok</groupId>
+            <artifactId>lombok</artifactId>
+            <version>1.18.30</version>

Review Comment:
   I think this should be a version in parent pom in the long term



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(ci): JDK 25 compilation failure [camel]

Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #19607:
URL: https://github.com/apache/camel/pull/19607#issuecomment-3414484501

   cc @apupier @davsclaus @oscerd @orpiske 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(ci): JDK 25 compilation failure [camel]

Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez merged PR #19607:
URL: https://github.com/apache/camel/pull/19607


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org