You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/03/18 16:30:33 UTC
[jira] [Commented] (FLINK-3634) Fix documentation for
DataSetUtils.zipWithUniqueId()
[ https://issues.apache.org/jira/browse/FLINK-3634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15201633#comment-15201633 ]
ASF GitHub Bot commented on FLINK-3634:
---------------------------------------
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/1817
[FLINK-3634] [docs] Fix documentation for DataSetUtils.zipWithUniqueId()
The example results now reflect recent improvements to the zipWith functions while contrasting the dense and sparse indexing.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink 3634_fix_documentation_for_datasetutils_zipwithuniqueid
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1817.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1817
----
commit aa0d89eca477066a600fd79a4d233492db709bff
Author: Greg Hogan <co...@greghogan.com>
Date: 2016-03-18T14:44:03Z
[FLINK-3634] [docs] Fix documentation for DataSetUtils.zipWithUniqueId()
----
> Fix documentation for DataSetUtils.zipWithUniqueId()
> ----------------------------------------------------
>
> Key: FLINK-3634
> URL: https://issues.apache.org/jira/browse/FLINK-3634
> Project: Flink
> Issue Type: Improvement
> Components: Documentation
> Affects Versions: 1.1.0
> Reporter: Greg Hogan
> Assignee: Greg Hogan
> Priority: Minor
> Fix For: 1.1.0, 1.0.1
>
>
> Under FLINK-2590 the assignment and testing of unique IDs was improved but the documentation looks to still reference the old implementation.
> With {{parallelism=1}} there is no difference between zipWithUniqueID and zipWithIndex. With greater parallelism the results of zipWithUniqueID are dependent on the partitioning.
> The documentation should demonstrate a possible result that is different from the incremental sequence of zipWithIndex while noting that results are dependent on the parallelism and partitioning.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)