You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/02/21 01:35:25 UTC
[GitHub] gianm commented on a change in pull request #7116: segment metadata
fallback analysis if no bitmaps
gianm commented on a change in pull request #7116: segment metadata fallback analysis if no bitmaps
URL: https://github.com/apache/incubator-druid/pull/7116#discussion_r258748927
##########
File path: processing/src/test/java/org/apache/druid/query/metadata/SegmentMetadataQueryTest.java
##########
@@ -83,10 +83,15 @@
public static QueryRunner makeMMappedQueryRunner(
SegmentId segmentId,
boolean rollup,
+ boolean bitmaps,
QueryRunnerFactory factory
)
{
- QueryableIndex index = rollup ? TestIndex.getMMappedTestIndex() : TestIndex.getNoRollupMMappedTestIndex();
+ QueryableIndex index = bitmaps
+ ? rollup
Review comment:
Nested ternaries = ðŸ˜. Please consider using normal `if`s.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org