You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openwebbeans.apache.org by "Mark Struberg (JIRA)" <ji...@apache.org> on 2009/02/05 22:24:59 UTC
[jira] Updated: (OWB-75) create SPI integration support
[ https://issues.apache.org/jira/browse/OWB-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Struberg updated OWB-75:
-----------------------------
Attachment: OWB-75.patch
please review this patch, so I can commit it after M1 is released
> create SPI integration support
> ------------------------------
>
> Key: OWB-75
> URL: https://issues.apache.org/jira/browse/OWB-75
> Project: OpenWebBeans
> Issue Type: New Feature
> Reporter: Mark Struberg
> Assignee: Mark Struberg
> Attachments: OWB-75.patch
>
>
> All Resources/Utilities which are depending on a specific environment must only be accessed via services which are provided via a Service Provider Interface.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Updated: (OWB-75) create SPI integration support
Posted by Gurkan Erdogdu <gu...@yahoo.com>.
+1
________________________________
From: Mark Struberg <st...@yahoo.de>
To: openwebbeans-dev@incubator.apache.org
Sent: Friday, February 6, 2009 11:10:06 AM
Subject: Re: [jira] Updated: (OWB-75) create SPI integration support
Basically you are right, but from the practical side: we could only factor out the interfaces and the ServiceLoader and webbeans-spi has to be a dependency for webbeans-impl. The 'default implementations' of the services needed still have to be inside webbeans-impl, because we couldn't run _any_ tests without it.
So, I argue for currently having all in webbeans-impl, and once we agree on the final interfaces, we can still move it to an own module.
LieGrue,
strub
--- Gurkan Erdogdu <gu...@yahoo.com> schrieb am Fr, 6.2.2009:
> Von: Gurkan Erdogdu <gu...@yahoo.com>
> Betreff: Re: [jira] Updated: (OWB-75) create SPI integration support
> An: openwebbeans-dev@incubator.apache.org
> Datum: Freitag, 6. Februar 2009, 6:09
> Hi Mark;
>
> Looks very good!. Some thoughts : It seems from the patch
> that SPI interface codes are under the *webbeans-impl*
> module. Can we create another module (webbeans-spi) and put
> SPI interface codes and SPI specific util classes into it?
>
> WDYT?
>
> In the mean time, I have branched the M1 version. So, you
> could commit to the code into the trunk after running the
> tests successfully.
>
> Thanks;
>
>
>
>
> ________________________________
> From: Mark Struberg (JIRA) <ji...@apache.org>
> To: openwebbeans-dev@incubator.apache.org
> Sent: Thursday, February 5, 2009 11:24:59 PM
> Subject: [jira] Updated: (OWB-75) create SPI integration
> support
>
>
> [
> https://issues.apache.org/jira/browse/OWB-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> ]
>
> Mark Struberg updated OWB-75:
> -----------------------------
>
> Attachment: OWB-75.patch
>
> please review this patch, so I can commit it after M1 is
> released
>
> > create SPI integration support
> > ------------------------------
> >
> > Key: OWB-75
> > URL:
> https://issues.apache.org/jira/browse/OWB-75
> > Project: OpenWebBeans
> > Issue Type: New Feature
> > Reporter: Mark Struberg
> > Assignee: Mark Struberg
> > Attachments: OWB-75.patch
> >
> >
> > All Resources/Utilities which are depending on a
> specific environment must only be accessed via services
> which are provided via a Service Provider Interface.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue
> online.
Re: [jira] Updated: (OWB-75) create SPI integration support
Posted by Mark Struberg <st...@yahoo.de>.
Basically you are right, but from the practical side: we could only factor out the interfaces and the ServiceLoader and webbeans-spi has to be a dependency for webbeans-impl. The 'default implementations' of the services needed still have to be inside webbeans-impl, because we couldn't run _any_ tests without it.
So, I argue for currently having all in webbeans-impl, and once we agree on the final interfaces, we can still move it to an own module.
LieGrue,
strub
--- Gurkan Erdogdu <gu...@yahoo.com> schrieb am Fr, 6.2.2009:
> Von: Gurkan Erdogdu <gu...@yahoo.com>
> Betreff: Re: [jira] Updated: (OWB-75) create SPI integration support
> An: openwebbeans-dev@incubator.apache.org
> Datum: Freitag, 6. Februar 2009, 6:09
> Hi Mark;
>
> Looks very good!. Some thoughts : It seems from the patch
> that SPI interface codes are under the *webbeans-impl*
> module. Can we create another module (webbeans-spi) and put
> SPI interface codes and SPI specific util classes into it?
>
> WDYT?
>
> In the mean time, I have branched the M1 version. So, you
> could commit to the code into the trunk after running the
> tests successfully.
>
> Thanks;
>
>
>
>
> ________________________________
> From: Mark Struberg (JIRA) <ji...@apache.org>
> To: openwebbeans-dev@incubator.apache.org
> Sent: Thursday, February 5, 2009 11:24:59 PM
> Subject: [jira] Updated: (OWB-75) create SPI integration
> support
>
>
> [
> https://issues.apache.org/jira/browse/OWB-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> ]
>
> Mark Struberg updated OWB-75:
> -----------------------------
>
> Attachment: OWB-75.patch
>
> please review this patch, so I can commit it after M1 is
> released
>
> > create SPI integration support
> > ------------------------------
> >
> > Key: OWB-75
> > URL:
> https://issues.apache.org/jira/browse/OWB-75
> > Project: OpenWebBeans
> > Issue Type: New Feature
> > Reporter: Mark Struberg
> > Assignee: Mark Struberg
> > Attachments: OWB-75.patch
> >
> >
> > All Resources/Utilities which are depending on a
> specific environment must only be accessed via services
> which are provided via a Service Provider Interface.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue
> online.
Re: [jira] Updated: (OWB-75) create SPI integration support
Posted by Gurkan Erdogdu <gu...@yahoo.com>.
Hi Mark;
Looks very good!. Some thoughts : It seems from the patch that SPI interface codes are under the *webbeans-impl* module. Can we create another module (webbeans-spi) and put SPI interface codes and SPI specific util classes into it?
WDYT?
In the mean time, I have branched the M1 version. So, you could commit to the code into the trunk after running the tests successfully.
Thanks;
________________________________
From: Mark Struberg (JIRA) <ji...@apache.org>
To: openwebbeans-dev@incubator.apache.org
Sent: Thursday, February 5, 2009 11:24:59 PM
Subject: [jira] Updated: (OWB-75) create SPI integration support
[ https://issues.apache.org/jira/browse/OWB-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Struberg updated OWB-75:
-----------------------------
Attachment: OWB-75.patch
please review this patch, so I can commit it after M1 is released
> create SPI integration support
> ------------------------------
>
> Key: OWB-75
> URL: https://issues.apache.org/jira/browse/OWB-75
> Project: OpenWebBeans
> Issue Type: New Feature
> Reporter: Mark Struberg
> Assignee: Mark Struberg
> Attachments: OWB-75.patch
>
>
> All Resources/Utilities which are depending on a specific environment must only be accessed via services which are provided via a Service Provider Interface.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.