[GitHub] [spark] Tonix517 commented on a change in pull request #25055: [SPARK-28189][SQL] Use semanticEquals in Dataset drop method for attributes comparison

[GitBox <gi...@apache.org>]

Tonix517 commented on a change in pull request #25055: [SPARK-28189][SQL] Use semanticEquals in Dataset drop method for attributes comparison
URL: https://github.com/apache/spark/pull/25055#discussion_r300543823
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
 ##########
 @@ -572,6 +572,22 @@ class DataFrameSuite extends QueryTest with SharedSQLContext {
     assert(df.schema.map(_.name) === Seq("value"))
   }
 
+  test("drop column using drop with column reference with case-insensitive names") {
+    val col1 = testData("KEY")
 
 Review comment:
   With that flag set as `true`, an exception was thrown out `org.apache.spark.sql.AnalysisException: Cannot resolve column name "KEY" among (key, value);`. It looks to be the correct behavior in that case. do I still need to check it in this test case and make sure such exception is thrown and caught?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org