[GitHub] [beam] JozoVilcek commented on a change in pull request #13543: [BEAM-11457] Add option to skip key-value clone

[GitBox <gi...@apache.org>]

JozoVilcek commented on a change in pull request #13543:
URL: https://github.com/apache/beam/pull/13543#discussion_r550431621



##########
File path: sdks/java/io/hadoop-format/src/main/java/org/apache/beam/sdk/io/hadoop/format/HadoopFormatIO.java
##########
@@ -475,6 +479,18 @@
       return withValueTranslation(function).toBuilder().setValueCoder(coder).build();
     }
 
+    /**
+     * Determines if key-value clone should be skipped or not (default is 'false'). Hadoop formats
+     * typically work with Writable data structures which are mutable. Therefore, this IO will clone
+     * read key-values if they are not in the list of well known immutable types. However, in case
+     * user does use key/value translation functions, resulting key-values might already be

Review comment:
       I would keep it separate. I am not sure if there are some input formats out there which can be not reusing instances of does not use writables for serialization.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org