[GitHub] incubator-zeppelin pull request: Zeppelin-web Spring Cleaning

[felizbear <gi...@git.apache.org>]

Github user felizbear commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/56#issuecomment-111350416
  
    @corneadoug I skimmed through the last three commits. It looks like you did a nice job. Using `controller as` pattern is definitely an improvement. The other thing I have to mention that services are singletons (https://github.com/johnpapa/angular-styleguide#singletons), so you'll be better off returning an object instead of using `this`.
    E.g.
    ```javascript
    this.deleteNotebook = function(noteId) {}
    this.getNotebookList = function() {}
    ```
    would become
    ```javascript
    return {
      deleteNotebook = function() {},
      getNotebookList = function() {}
    }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---