You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/06/26 12:50:00 UTC
[GitHub] [hudi] yabola opened a new pull request, #5978: HUDI-4284 Implement bloom lookup tree as red-black tree
yabola opened a new pull request, #5978:
URL: https://github.com/apache/hudi/pull/5978
## What is the purpose of the pull request
The existing KeyRangeLookupTree implementation is Binary Sorting Tree.
Although it is shuffled before insertion, it may still cause uneven distribution. This PR implement it as a Red Black Tree.
## Brief change log
Added abstract implementation of red-black tree. and implement the `KeyRangeLookupTree` as red-black tree.
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5978: [HUDI-4284] Implement index lookup tree as red-black tree
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5978:
URL: https://github.com/apache/hudi/pull/5978#issuecomment-1166565781
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "53e67f61f0f1f0d1527a51f291ae2e7c65894ffc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9553",
"triggerID" : "53e67f61f0f1f0d1527a51f291ae2e7c65894ffc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 53e67f61f0f1f0d1527a51f291ae2e7c65894ffc Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9553)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5978: [HUDI-4284] Implement bloom lookup tree as red-black tree
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5978:
URL: https://github.com/apache/hudi/pull/5978#issuecomment-1167256830
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "53e67f61f0f1f0d1527a51f291ae2e7c65894ffc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9553",
"triggerID" : "53e67f61f0f1f0d1527a51f291ae2e7c65894ffc",
"triggerType" : "PUSH"
}, {
"hash" : "a8f041f0155282e4f240543bc2f34e00023cd46d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9559",
"triggerID" : "a8f041f0155282e4f240543bc2f34e00023cd46d",
"triggerType" : "PUSH"
}, {
"hash" : "49b5aa8f41e3555de10a6f3a813a2daf5160aaff",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9560",
"triggerID" : "49b5aa8f41e3555de10a6f3a813a2daf5160aaff",
"triggerType" : "PUSH"
}, {
"hash" : "34f0288415460a1938af792d7dff9bba36525884",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9590",
"triggerID" : "34f0288415460a1938af792d7dff9bba36525884",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 49b5aa8f41e3555de10a6f3a813a2daf5160aaff Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9560)
* 34f0288415460a1938af792d7dff9bba36525884 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9590)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on a diff in pull request #5978: [HUDI-4284] Implement bloom lookup tree as red-black tree
Posted by GitBox <gi...@apache.org>.
codope commented on code in PR #5978:
URL: https://github.com/apache/hudi/pull/5978#discussion_r1005125747
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/index/bloom/TestKeyRangeLookupTree.java:
##########
@@ -165,12 +194,29 @@ private void updateExpectedMatchesToTest(KeyRangeNode toInsert) {
long startKey = Long.parseLong(toInsert.getMinRecordKey());
long endKey = Long.parseLong(toInsert.getMaxRecordKey());
for (long i = startKey; i <= endKey; i++) {
- String iStr = Long.toString(i);
+ String iStr = alignedNumber(i);
if (!expectedMatches.containsKey(iStr)) {
expectedMatches.put(iStr, new HashSet<>());
}
expectedMatches.get(iStr).add(toInsert.getFileNameList().get(0));
}
}
+ /**
+ * Method to align the number of digits. The key's comparison is in lexicographic order, so we need to fill in the numbers.
+ *
+ * @param key the numeric value of the key
+ * @return result of aligned numbers. For example, `1` -> `00001`.
+ */
+ private String alignedNumber(long key) {
Review Comment:
Can be static?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/bloom/IntervalTreeBasedGlobalIndexFileFilter.java:
##########
@@ -51,10 +50,6 @@ class IntervalTreeBasedGlobalIndexFileFilter implements IndexFileFilter {
allIndexFiles.add(file);
}));
- // Note that the interval tree implementation doesn't have auto-balancing to ensure logN search time.
- // So, we are shuffling the input here hoping the tree will not have any skewness. If not, the tree could be skewed
- // which could result in N search time instead of NlogN.
- Collections.shuffle(allIndexFiles);
Review Comment:
@yabola do you have some micro-benchmark as to how much improvement this change brings?
##########
hudi-common/src/main/java/org/apache/hudi/common/util/rbtree/RedBlackTree.java:
##########
@@ -0,0 +1,419 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.common.util.rbtree;
+
+import java.io.Serializable;
+
+/**
+ * Red–black tree is a kind of self-balancing binary search tree. Each node has its "color" ("red" or "black"),
+ * used to ensure that the tree remains balanced during insertions and deletions. The re-balancing is not perfect,
+ * but guarantees searching in O(log N) time, where n is the number of entries.
+ * In addition to the requirements imposed on a binary search tree, the following must be satisfied by a red–black tree:
+ * 1. Every node has a color either red or black.
+ * 2. The root of the tree is always black.
+ * 3. There are no two adjacent red nodes (A red node cannot have a red parent or red child).
+ * 4. Every path from a node (including root) to any of its descendants NULL nodes has the same number of black nodes.
+ */
+@SuppressWarnings({"unchecked", "rawtypes"})
+public class RedBlackTree<T extends RedBlackTreeNode<K>, K extends Comparable<K>> implements Serializable {
Review Comment:
Have you considered thread safety of operations on the tree?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5978: [HUDI-4284] Implement bloom lookup tree as red-black tree
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5978:
URL: https://github.com/apache/hudi/pull/5978#issuecomment-1167253275
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "53e67f61f0f1f0d1527a51f291ae2e7c65894ffc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9553",
"triggerID" : "53e67f61f0f1f0d1527a51f291ae2e7c65894ffc",
"triggerType" : "PUSH"
}, {
"hash" : "a8f041f0155282e4f240543bc2f34e00023cd46d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9559",
"triggerID" : "a8f041f0155282e4f240543bc2f34e00023cd46d",
"triggerType" : "PUSH"
}, {
"hash" : "49b5aa8f41e3555de10a6f3a813a2daf5160aaff",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9560",
"triggerID" : "49b5aa8f41e3555de10a6f3a813a2daf5160aaff",
"triggerType" : "PUSH"
}, {
"hash" : "34f0288415460a1938af792d7dff9bba36525884",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "34f0288415460a1938af792d7dff9bba36525884",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 49b5aa8f41e3555de10a6f3a813a2daf5160aaff Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9560)
* 34f0288415460a1938af792d7dff9bba36525884 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5978: [HUDI-4284] Implement bloom lookup tree as red-black tree
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5978:
URL: https://github.com/apache/hudi/pull/5978#issuecomment-1292792778
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "53e67f61f0f1f0d1527a51f291ae2e7c65894ffc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9553",
"triggerID" : "53e67f61f0f1f0d1527a51f291ae2e7c65894ffc",
"triggerType" : "PUSH"
}, {
"hash" : "a8f041f0155282e4f240543bc2f34e00023cd46d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9559",
"triggerID" : "a8f041f0155282e4f240543bc2f34e00023cd46d",
"triggerType" : "PUSH"
}, {
"hash" : "49b5aa8f41e3555de10a6f3a813a2daf5160aaff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9560",
"triggerID" : "49b5aa8f41e3555de10a6f3a813a2daf5160aaff",
"triggerType" : "PUSH"
}, {
"hash" : "34f0288415460a1938af792d7dff9bba36525884",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9590",
"triggerID" : "34f0288415460a1938af792d7dff9bba36525884",
"triggerType" : "PUSH"
}, {
"hash" : "1598d995433bd8f85b1d6b6b0bd9b0a76cae37b7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12603",
"triggerID" : "1598d995433bd8f85b1d6b6b0bd9b0a76cae37b7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1598d995433bd8f85b1d6b6b0bd9b0a76cae37b7 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12603)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yabola commented on a diff in pull request #5978: [HUDI-4284] Implement bloom lookup tree as red-black tree
Posted by GitBox <gi...@apache.org>.
yabola commented on code in PR #5978:
URL: https://github.com/apache/hudi/pull/5978#discussion_r1005920717
##########
hudi-common/src/main/java/org/apache/hudi/common/util/rbtree/RedBlackTree.java:
##########
@@ -0,0 +1,419 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.common.util.rbtree;
+
+import java.io.Serializable;
+
+/**
+ * Red–black tree is a kind of self-balancing binary search tree. Each node has its "color" ("red" or "black"),
+ * used to ensure that the tree remains balanced during insertions and deletions. The re-balancing is not perfect,
+ * but guarantees searching in O(log N) time, where n is the number of entries.
+ * In addition to the requirements imposed on a binary search tree, the following must be satisfied by a red–black tree:
+ * 1. Every node has a color either red or black.
+ * 2. The root of the tree is always black.
+ * 3. There are no two adjacent red nodes (A red node cannot have a red parent or red child).
+ * 4. Every path from a node (including root) to any of its descendants NULL nodes has the same number of black nodes.
+ */
+@SuppressWarnings({"unchecked", "rawtypes"})
+public class RedBlackTree<T extends RedBlackTreeNode<K>, K extends Comparable<K>> implements Serializable {
Review Comment:
I can make this tree thread safety later if need
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5978: [HUDI-4284] Implement bloom lookup tree as red-black tree
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5978:
URL: https://github.com/apache/hudi/pull/5978#issuecomment-1292310859
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "53e67f61f0f1f0d1527a51f291ae2e7c65894ffc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9553",
"triggerID" : "53e67f61f0f1f0d1527a51f291ae2e7c65894ffc",
"triggerType" : "PUSH"
}, {
"hash" : "a8f041f0155282e4f240543bc2f34e00023cd46d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9559",
"triggerID" : "a8f041f0155282e4f240543bc2f34e00023cd46d",
"triggerType" : "PUSH"
}, {
"hash" : "49b5aa8f41e3555de10a6f3a813a2daf5160aaff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9560",
"triggerID" : "49b5aa8f41e3555de10a6f3a813a2daf5160aaff",
"triggerType" : "PUSH"
}, {
"hash" : "34f0288415460a1938af792d7dff9bba36525884",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9590",
"triggerID" : "34f0288415460a1938af792d7dff9bba36525884",
"triggerType" : "PUSH"
}, {
"hash" : "1598d995433bd8f85b1d6b6b0bd9b0a76cae37b7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12603",
"triggerID" : "1598d995433bd8f85b1d6b6b0bd9b0a76cae37b7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 34f0288415460a1938af792d7dff9bba36525884 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9590)
* 1598d995433bd8f85b1d6b6b0bd9b0a76cae37b7 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12603)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yabola commented on pull request #5978: [HUDI-4284] Implement bloom lookup tree as red-black tree
Posted by GitBox <gi...@apache.org>.
yabola commented on PR #5978:
URL: https://github.com/apache/hudi/pull/5978#issuecomment-1203413075
@vinothchandar Can you help review this PR, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5978: [HUDI-4284] Implement bloom lookup tree as red-black tree
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5978:
URL: https://github.com/apache/hudi/pull/5978#issuecomment-1166582889
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "53e67f61f0f1f0d1527a51f291ae2e7c65894ffc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9553",
"triggerID" : "53e67f61f0f1f0d1527a51f291ae2e7c65894ffc",
"triggerType" : "PUSH"
}, {
"hash" : "a8f041f0155282e4f240543bc2f34e00023cd46d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a8f041f0155282e4f240543bc2f34e00023cd46d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 53e67f61f0f1f0d1527a51f291ae2e7c65894ffc Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9553)
* a8f041f0155282e4f240543bc2f34e00023cd46d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yabola commented on a diff in pull request #5978: [HUDI-4284] Implement bloom lookup tree as red-black tree
Posted by GitBox <gi...@apache.org>.
yabola commented on code in PR #5978:
URL: https://github.com/apache/hudi/pull/5978#discussion_r1005912907
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/bloom/IntervalTreeBasedGlobalIndexFileFilter.java:
##########
@@ -51,10 +50,6 @@ class IntervalTreeBasedGlobalIndexFileFilter implements IndexFileFilter {
allIndexFiles.add(file);
}));
- // Note that the interval tree implementation doesn't have auto-balancing to ensure logN search time.
- // So, we are shuffling the input here hoping the tree will not have any skewness. If not, the tree could be skewed
- // which could result in N search time instead of NlogN.
- Collections.shuffle(allIndexFiles);
Review Comment:
Sorry, actually I don't have benchmark on it. I think red-black tree is a general optimization strategy like hashmap
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5978: [HUDI-4284] Implement bloom lookup tree as red-black tree
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5978:
URL: https://github.com/apache/hudi/pull/5978#issuecomment-1166583994
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "53e67f61f0f1f0d1527a51f291ae2e7c65894ffc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9553",
"triggerID" : "53e67f61f0f1f0d1527a51f291ae2e7c65894ffc",
"triggerType" : "PUSH"
}, {
"hash" : "a8f041f0155282e4f240543bc2f34e00023cd46d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9559",
"triggerID" : "a8f041f0155282e4f240543bc2f34e00023cd46d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 53e67f61f0f1f0d1527a51f291ae2e7c65894ffc Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9553)
* a8f041f0155282e4f240543bc2f34e00023cd46d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9559)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5978: [HUDI-4284] Implement bloom lookup tree as red-black tree
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5978:
URL: https://github.com/apache/hudi/pull/5978#issuecomment-1166598276
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "53e67f61f0f1f0d1527a51f291ae2e7c65894ffc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9553",
"triggerID" : "53e67f61f0f1f0d1527a51f291ae2e7c65894ffc",
"triggerType" : "PUSH"
}, {
"hash" : "a8f041f0155282e4f240543bc2f34e00023cd46d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9559",
"triggerID" : "a8f041f0155282e4f240543bc2f34e00023cd46d",
"triggerType" : "PUSH"
}, {
"hash" : "49b5aa8f41e3555de10a6f3a813a2daf5160aaff",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "49b5aa8f41e3555de10a6f3a813a2daf5160aaff",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 53e67f61f0f1f0d1527a51f291ae2e7c65894ffc Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9553)
* a8f041f0155282e4f240543bc2f34e00023cd46d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9559)
* 49b5aa8f41e3555de10a6f3a813a2daf5160aaff UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5978: [HUDI-4284] Implement bloom lookup tree as red-black tree
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5978:
URL: https://github.com/apache/hudi/pull/5978#issuecomment-1167833711
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "53e67f61f0f1f0d1527a51f291ae2e7c65894ffc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9553",
"triggerID" : "53e67f61f0f1f0d1527a51f291ae2e7c65894ffc",
"triggerType" : "PUSH"
}, {
"hash" : "a8f041f0155282e4f240543bc2f34e00023cd46d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9559",
"triggerID" : "a8f041f0155282e4f240543bc2f34e00023cd46d",
"triggerType" : "PUSH"
}, {
"hash" : "49b5aa8f41e3555de10a6f3a813a2daf5160aaff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9560",
"triggerID" : "49b5aa8f41e3555de10a6f3a813a2daf5160aaff",
"triggerType" : "PUSH"
}, {
"hash" : "34f0288415460a1938af792d7dff9bba36525884",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9590",
"triggerID" : "34f0288415460a1938af792d7dff9bba36525884",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 34f0288415460a1938af792d7dff9bba36525884 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9590)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5978: [HUDI-4284] Implement bloom lookup tree as red-black tree
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5978:
URL: https://github.com/apache/hudi/pull/5978#issuecomment-1166655645
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "53e67f61f0f1f0d1527a51f291ae2e7c65894ffc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9553",
"triggerID" : "53e67f61f0f1f0d1527a51f291ae2e7c65894ffc",
"triggerType" : "PUSH"
}, {
"hash" : "a8f041f0155282e4f240543bc2f34e00023cd46d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9559",
"triggerID" : "a8f041f0155282e4f240543bc2f34e00023cd46d",
"triggerType" : "PUSH"
}, {
"hash" : "49b5aa8f41e3555de10a6f3a813a2daf5160aaff",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9560",
"triggerID" : "49b5aa8f41e3555de10a6f3a813a2daf5160aaff",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 49b5aa8f41e3555de10a6f3a813a2daf5160aaff Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9560)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yabola commented on pull request #5978: [HUDI-4284] Implement bloom lookup tree as red-black tree
Posted by GitBox <gi...@apache.org>.
yabola commented on PR #5978:
URL: https://github.com/apache/hudi/pull/5978#issuecomment-1171953315
@codope Please take a look~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yabola commented on pull request #5978: [HUDI-4284] Implement bloom lookup tree as red-black tree
Posted by GitBox <gi...@apache.org>.
yabola commented on PR #5978:
URL: https://github.com/apache/hudi/pull/5978#issuecomment-1290861099
@yihua Hi, if you have time, can you help review my PR, thanks~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5978: [HUDI-4284] Implement index lookup tree as red-black tree
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5978:
URL: https://github.com/apache/hudi/pull/5978#issuecomment-1166532800
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "53e67f61f0f1f0d1527a51f291ae2e7c65894ffc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "53e67f61f0f1f0d1527a51f291ae2e7c65894ffc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 53e67f61f0f1f0d1527a51f291ae2e7c65894ffc UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5978: [HUDI-4284] Implement index lookup tree as red-black tree
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5978:
URL: https://github.com/apache/hudi/pull/5978#issuecomment-1166533795
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "53e67f61f0f1f0d1527a51f291ae2e7c65894ffc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9553",
"triggerID" : "53e67f61f0f1f0d1527a51f291ae2e7c65894ffc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 53e67f61f0f1f0d1527a51f291ae2e7c65894ffc Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9553)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5978: [HUDI-4284] Implement bloom lookup tree as red-black tree
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5978:
URL: https://github.com/apache/hudi/pull/5978#issuecomment-1166599159
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "53e67f61f0f1f0d1527a51f291ae2e7c65894ffc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9553",
"triggerID" : "53e67f61f0f1f0d1527a51f291ae2e7c65894ffc",
"triggerType" : "PUSH"
}, {
"hash" : "a8f041f0155282e4f240543bc2f34e00023cd46d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9559",
"triggerID" : "a8f041f0155282e4f240543bc2f34e00023cd46d",
"triggerType" : "PUSH"
}, {
"hash" : "49b5aa8f41e3555de10a6f3a813a2daf5160aaff",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9560",
"triggerID" : "49b5aa8f41e3555de10a6f3a813a2daf5160aaff",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 53e67f61f0f1f0d1527a51f291ae2e7c65894ffc Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9553)
* a8f041f0155282e4f240543bc2f34e00023cd46d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9559)
* 49b5aa8f41e3555de10a6f3a813a2daf5160aaff Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9560)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5978: [HUDI-4284] Implement bloom lookup tree as red-black tree
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5978:
URL: https://github.com/apache/hudi/pull/5978#issuecomment-1166629056
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "53e67f61f0f1f0d1527a51f291ae2e7c65894ffc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9553",
"triggerID" : "53e67f61f0f1f0d1527a51f291ae2e7c65894ffc",
"triggerType" : "PUSH"
}, {
"hash" : "a8f041f0155282e4f240543bc2f34e00023cd46d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9559",
"triggerID" : "a8f041f0155282e4f240543bc2f34e00023cd46d",
"triggerType" : "PUSH"
}, {
"hash" : "49b5aa8f41e3555de10a6f3a813a2daf5160aaff",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9560",
"triggerID" : "49b5aa8f41e3555de10a6f3a813a2daf5160aaff",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a8f041f0155282e4f240543bc2f34e00023cd46d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9559)
* 49b5aa8f41e3555de10a6f3a813a2daf5160aaff Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9560)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on pull request #5978: [HUDI-4284] Implement bloom lookup tree as red-black tree
Posted by GitBox <gi...@apache.org>.
codope commented on PR #5978:
URL: https://github.com/apache/hudi/pull/5978#issuecomment-1210475034
@yabola Thanks for putting up this PR. Sorry for the delay as I was occupied with Hudi release work. I am going to review it towards the end of week. Expect feedback by Monday.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yabola commented on a diff in pull request #5978: [HUDI-4284] Implement bloom lookup tree as red-black tree
Posted by GitBox <gi...@apache.org>.
yabola commented on code in PR #5978:
URL: https://github.com/apache/hudi/pull/5978#discussion_r1005920717
##########
hudi-common/src/main/java/org/apache/hudi/common/util/rbtree/RedBlackTree.java:
##########
@@ -0,0 +1,419 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hudi.common.util.rbtree;
+
+import java.io.Serializable;
+
+/**
+ * Red–black tree is a kind of self-balancing binary search tree. Each node has its "color" ("red" or "black"),
+ * used to ensure that the tree remains balanced during insertions and deletions. The re-balancing is not perfect,
+ * but guarantees searching in O(log N) time, where n is the number of entries.
+ * In addition to the requirements imposed on a binary search tree, the following must be satisfied by a red–black tree:
+ * 1. Every node has a color either red or black.
+ * 2. The root of the tree is always black.
+ * 3. There are no two adjacent red nodes (A red node cannot have a red parent or red child).
+ * 4. Every path from a node (including root) to any of its descendants NULL nodes has the same number of black nodes.
+ */
+@SuppressWarnings({"unchecked", "rawtypes"})
+public class RedBlackTree<T extends RedBlackTreeNode<K>, K extends Comparable<K>> implements Serializable {
Review Comment:
If we need to thread-safe use of the tree, I think we may need to lock the whole tree. So what about adding the `synchronized` or other lock when we use this tree?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5978: [HUDI-4284] Implement bloom lookup tree as red-black tree
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5978:
URL: https://github.com/apache/hudi/pull/5978#issuecomment-1292304173
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "53e67f61f0f1f0d1527a51f291ae2e7c65894ffc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9553",
"triggerID" : "53e67f61f0f1f0d1527a51f291ae2e7c65894ffc",
"triggerType" : "PUSH"
}, {
"hash" : "a8f041f0155282e4f240543bc2f34e00023cd46d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9559",
"triggerID" : "a8f041f0155282e4f240543bc2f34e00023cd46d",
"triggerType" : "PUSH"
}, {
"hash" : "49b5aa8f41e3555de10a6f3a813a2daf5160aaff",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9560",
"triggerID" : "49b5aa8f41e3555de10a6f3a813a2daf5160aaff",
"triggerType" : "PUSH"
}, {
"hash" : "34f0288415460a1938af792d7dff9bba36525884",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9590",
"triggerID" : "34f0288415460a1938af792d7dff9bba36525884",
"triggerType" : "PUSH"
}, {
"hash" : "1598d995433bd8f85b1d6b6b0bd9b0a76cae37b7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1598d995433bd8f85b1d6b6b0bd9b0a76cae37b7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 34f0288415460a1938af792d7dff9bba36525884 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9590)
* 1598d995433bd8f85b1d6b6b0bd9b0a76cae37b7 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org