You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ofbiz.apache.org by Jacques Le Roux <ja...@les7arts.com> on 2013/10/05 11:02:50 UTC

About OFBIZ-5338

Hi,

I fxed a common issue to 3 services at https://issues.apache.org/jira/browse/OFBIZ-5338

Doing so, I wondered if we could not generalise by removing responseMessage from results-to-map

I refrained myself to do so because in certain (very rare) cases responseMessage could have an interested.
But I really doubt, because if the called service succeed I don't see why we should keep responseMessage in the returned map. It's more an error prone stuff IMO

Opinions?

Jacques

Re: About OFBIZ-5338

Posted by Jacques Le Roux <ja...@les7arts.com>.

Thanks Jacopo,

I agree, I will revert r1529415 and will rather do that, much cleaner

Jacques

Jacopo Cappellato wrote:
> On Oct 5, 2013, at 11:02 AM, Jacques Le Roux <ja...@les7arts.com> wrote:
> 
>> Hi,
>> 
>> I fxed a common issue to 3 services at https://issues.apache.org/jira/browse/OFBIZ-5338
>> 
>> Doing so, I wondered if we could not generalise by removing responseMessage from results-to-map
> 
> In this case it may be a better approach to modify the behavior of field-to-result: skip the field if it is not part of the OUT
> attributes and print instead a warning message. 
> 
> Jacopo
> 
>> 
>> I refrained myself to do so because in certain (very rare) cases responseMessage could have an interested.
>> But I really doubt, because if the called service succeed I don't see why we should keep responseMessage in the returned map.
>> It's more an error prone stuff IMO 
>> 
>> Opinions?
>> 
>> Jacques

Re: About OFBIZ-5338

Posted by Jacopo Cappellato <ja...@hotwaxmedia.com>.

On Oct 5, 2013, at 11:02 AM, Jacques Le Roux <ja...@les7arts.com> wrote:

> Hi,
> 
> I fxed a common issue to 3 services at https://issues.apache.org/jira/browse/OFBIZ-5338
> 
> Doing so, I wondered if we could not generalise by removing responseMessage from results-to-map

In this case it may be a better approach to modify the behavior of field-to-result: skip the field if it is not part of the OUT attributes and print instead a warning message.

Jacopo

> 
> I refrained myself to do so because in certain (very rare) cases responseMessage could have an interested.
> But I really doubt, because if the called service succeed I don't see why we should keep responseMessage in the returned map. It's more an error prone stuff IMO
> 
> Opinions?
> 
> Jacques

Re: About OFBIZ-5338

Posted by Jacques Le Roux <ja...@les7arts.com>.

Any opinions?

Jacques

Jacques Le Roux wrote:
> Hi,
> 
> I fxed a common issue to 3 services at https://issues.apache.org/jira/browse/OFBIZ-5338
> 
> Doing so, I wondered if we could not generalise by removing responseMessage from results-to-map
> 
> I refrained myself to do so because in certain (very rare) cases responseMessage could have an interested.
> But I really doubt, because if the called service succeed I don't see why we should keep responseMessage in the returned map.
> It's more an error prone stuff IMO 
> 
> Opinions?
> 
> Jacques