You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/12 18:53:20 UTC

[GitHub] [arrow] andygrove commented on a change in pull request #8900: ARROW-10810: [Rust] Comparison kernels performance

andygrove commented on a change in pull request #8900:
URL: https://github.com/apache/arrow/pull/8900#discussion_r541726473



##########
File path: rust/arrow/src/array/array_binary.rs
##########
@@ -317,7 +317,7 @@ pub struct FixedSizeBinaryArray {
 impl FixedSizeBinaryArray {
     /// Returns the element at index `i` as a byte slice.
     pub fn value(&self, i: usize) -> &[u8] {
-        assert!(
+        debug_assert!(

Review comment:
       Does this change mean that we should mark the function as `unsafe`? Should we provide safe and unsafe versions of these functions?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org