You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by Jason Dere <jd...@hortonworks.com> on 2017/05/10 18:50:23 UTC

Review Request 59152: HIVE-16637 Improve end-of-data checking for LLAP input format

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59152/
-----------------------------------------------------------

Review request for hive, Sergey Shelukhin and Siddharth Seth.


Bugs: HIVE-16637
    https://issues.apache.org/jira/browse/HIVE-16637


Repository: hive-git


Description
-------

Fix the way we check end of data in LlapBaseRecordReader.next().
Also change communication from the LlapOutputFormatService to use a chunked format (series of <length indicator><bytes>), with a final 0-length chunk to indicate the end of the data stream.


Diffs
-----

  llap-client/src/java/org/apache/hadoop/hive/llap/LlapBaseRecordReader.java 59dec1b 
  llap-common/src/java/org/apache/hadoop/hive/llap/io/ChunkedInputStream.java PRE-CREATION 
  llap-common/src/java/org/apache/hadoop/hive/llap/io/ChunkedOutputStream.java PRE-CREATION 
  llap-common/src/test/org/apache/hadoop/hive/llap/io/TestChunkedInputStream.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/llap/LlapOutputFormatService.java 0619b79 


Diff: https://reviews.apache.org/r/59152/diff/1/


Testing
-------

Junit test added.


Thanks,

Jason Dere