[jira] [Commented] (YUNIKORN-1430) change go version check in Makefile

["Wilfred Spiegelenburg (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YUNIKORN-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641594#comment-17641594 ] 

Wilfred Spiegelenburg commented on YUNIKORN-1430:
-------------------------------------------------

as a generic comment for all three repos affected:

We need to move the install of go in the github actions to be the one of the first steps. It must be executed before we call any of the make commands. This means move:
{code:java}
      - name: Check license
        run: make license-check {code}
to after the
{code:java}
      - name: Set up Go
        uses: actions/setup-go@v3
        with:
          go-version-file: .go_version {code}
in the {{.github/workflows/main.yml}} or {{.github/workflows/pre-commit.yml}}

> change go version check in Makefile
> -----------------------------------
>
>                 Key: YUNIKORN-1430
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-1430
>             Project: Apache YuniKorn
>          Issue Type: Task
>          Components: build
>            Reporter: Wilfred Spiegelenburg
>            Assignee: Wu hsuang zong
>            Priority: Major
>              Labels: newbie, pull-request-available
>
> Although the project itself is still using just Go 1.16 some of the dependencies use later versions. We keep the version in {{.go_version}} up to date as it is used by the CI build.
> Update the Makefiles to use the {{.go_version}} file:
> {code:java}
> MOD_VERSION := $(shell awk '/^go/ {print $$2}' go.mod) {code}
> should be:
> {code:java}
> MOD_VERSION := $(shell cat .go_version) {code}
> that will cause the {{make}} to fail as expected if go is too old. All repos would need an update.
> This should be applied to _all_ repos that use go and thus have a {{.go_version}} file



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org