You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2020/07/05 13:20:48 UTC

[GitHub] [avro] tjwp opened a new pull request #928: AVRO-2382: Fix VERSION constant for Ruby gem

tjwp opened a new pull request #928:
URL: https://github.com/apache/avro/pull/928


   ### Jira
   
   This change fixes a long-standing annoyance that the Ruby gem does not contain an accurate version constant. There are many ways this could have been addressed. This was the simplest option that I could come up with given the current build.
   
   - [x] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title.
     - [https://issues.apache.org/jira/browse/AVRO-2382](https://issues.apache.org/jira/browse/AVRO-2382)
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   No tests added. This replaces the "FIXME" string with a real version value. The library fails to load if we are unable to read this value.
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines.
   
   ### Documentation
   
   N/A


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] RyanSkraba merged pull request #928: AVRO-2382: Fix VERSION constant for Ruby gem

Posted by GitBox <gi...@apache.org>.
RyanSkraba merged pull request #928:
URL: https://github.com/apache/avro/pull/928


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] tjwp commented on pull request #928: AVRO-2382: Fix VERSION constant for Ruby gem

Posted by GitBox <gi...@apache.org>.
tjwp commented on pull request #928:
URL: https://github.com/apache/avro/pull/928#issuecomment-655683749


   Thanks for the review Ryan!
   
   I went with this approach over a search-and-replace because it did not require a change to a file under version control whenever the release version changes while also ensuring that it always gets the correct version.
   
   If we had and automated search-and-replace process over the entire repo then I'd definitely go with hooking the Ruby build into that and would probably replace the version directly in the `lib/avro.rb` file.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] RyanSkraba commented on pull request #928: AVRO-2382: Fix VERSION constant for Ruby gem

Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on pull request #928:
URL: https://github.com/apache/avro/pull/928#issuecomment-656102604


   Thanks for the reasoning, I think it sounds great!  I'll cherry-pick this into `branch-1.10`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org