You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@causeway.apache.org by da...@apache.org on 2024/06/10 10:43:25 UTC

(causeway) 01/01: CAUSEWAY-3769: adds guard for param validation

This is an automated email from the ASF dual-hosted git repository.

danhaywood pushed a commit to branch CAUSEWAY-3769
in repository https://gitbox.apache.org/repos/asf/causeway.git

commit d14df0fafc80657bf412fe70e3107c599fc4a61d
Author: Dan Haywood <da...@haywood-associates.co.uk>
AuthorDate: Mon Jun 10 11:43:16 2024 +0100

    CAUSEWAY-3769: adds guard for param validation
    
    skip if the type is unknown.  for some reason, this is what we get for file uploads
---
 .../causeway/viewer/wicket/model/models/ScalarParameterModel.java   | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/viewers/wicket/model/src/main/java/org/apache/causeway/viewer/wicket/model/models/ScalarParameterModel.java b/viewers/wicket/model/src/main/java/org/apache/causeway/viewer/wicket/model/models/ScalarParameterModel.java
index e1f6d0a7b3..b83fdab3c3 100644
--- a/viewers/wicket/model/src/main/java/org/apache/causeway/viewer/wicket/model/models/ScalarParameterModel.java
+++ b/viewers/wicket/model/src/main/java/org/apache/causeway/viewer/wicket/model/models/ScalarParameterModel.java
@@ -28,6 +28,8 @@ import org.apache.causeway.core.metamodel.spec.feature.ObjectAction;
 import org.apache.causeway.viewer.commons.model.scalar.HasUiParameter;
 import org.apache.causeway.viewer.wicket.model.models.interaction.act.UiParameterWkt;
 
+import org.apache.wicket.markup.html.form.upload.FileUpload;
+
 import lombok.Getter;
 import lombok.NonNull;
 
@@ -59,6 +61,10 @@ implements HasUiParameter {
 
     @Override
     public String validate(final @NonNull ManagedObject proposedArg) {
+        // workaround for FileUpload
+        if(proposedArg.getSpecification().getBeanSort().isUnknown()) {
+            return null;
+        }
         proposedValue().getValue().setValue(proposedArg); // updates the pending parameter value
 
         //TODO [CAUSEWAY-3753] for some reason the ParameterModel.isValidationFeedbackActive() flag is not yet active,