You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Eiji Kitamura (JIRA)" <ji...@apache.org> on 2009/01/14 10:49:00 UTC
[jira] Created: (SHINDIG-854) OAuth miscellaneous bugs
OAuth miscellaneous bugs
------------------------
Key: SHINDIG-854
URL: https://issues.apache.org/jira/browse/SHINDIG-854
Project: Shindig
Issue Type: Improvement
Components: Gadget Rendering Server (PHP)
Affects Versions: trunk
Reporter: Eiji Kitamura
Priority: Trivial
Fix For: trunk
Attachments: OAuthFix.patch
1) OAuth/Service needs to have "name" attribute. Current implementation isn't complaining.
2) According to XSD, each url for OAuthServices (request, authorization, access) isn't mandatory. Current implementation is assuming they are existing.
3) parseEndPoint had better trim its paramers.
4) Some parameters (OAuth/Service@name, OAuth/Service/Request@url, OAuth/Service/Access@url, OAuth/Service/Authorization@url) are required but not checked on current code.
5) OAuth param_location isn't conforming to the spec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-854) OAuth miscellaneous bugs
Posted by "Eiji Kitamura (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eiji Kitamura updated SHINDIG-854:
----------------------------------
Attachment: OAuthFix2.patch
I've examined service@name part once again, and found yoichiro is right.
Attached is a patch the wrong part is ommited.
> OAuth miscellaneous bugs
> ------------------------
>
> Key: SHINDIG-854
> URL: https://issues.apache.org/jira/browse/SHINDIG-854
> Project: Shindig
> Issue Type: Improvement
> Components: Gadget Rendering Server (PHP)
> Affects Versions: trunk
> Reporter: Eiji Kitamura
> Assignee: Chris Chabot
> Priority: Trivial
> Fix For: trunk
>
> Attachments: OAuthFix.patch, OAuthFix2.patch
>
>
> 1) OAuth/Service needs to have "name" attribute. Current implementation isn't complaining.
> 2) According to XSD, each url for OAuthServices (request, authorization, access) isn't mandatory. Current implementation is assuming they are existing.
> 3) parseEndPoint had better trim its paramers.
> 4) Some parameters (OAuth/Service@name, OAuth/Service/Request@url, OAuth/Service/Access@url, OAuth/Service/Authorization@url) are required but not checked on current code.
> 5) OAuth param_location isn't conforming to the spec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SHINDIG-854) OAuth miscellaneous bugs
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Chabot closed SHINDIG-854.
--------------------------------
updated patch has been committed, thanks for the fixes!
> OAuth miscellaneous bugs
> ------------------------
>
> Key: SHINDIG-854
> URL: https://issues.apache.org/jira/browse/SHINDIG-854
> Project: Shindig
> Issue Type: Improvement
> Components: Gadget Rendering Server (PHP)
> Affects Versions: trunk
> Reporter: Eiji Kitamura
> Assignee: Chris Chabot
> Priority: Trivial
> Fix For: trunk
>
> Attachments: OAuthFix.patch, OAuthFix2.patch
>
>
> 1) OAuth/Service needs to have "name" attribute. Current implementation isn't complaining.
> 2) According to XSD, each url for OAuthServices (request, authorization, access) isn't mandatory. Current implementation is assuming they are existing.
> 3) parseEndPoint had better trim its paramers.
> 4) Some parameters (OAuth/Service@name, OAuth/Service/Request@url, OAuth/Service/Access@url, OAuth/Service/Authorization@url) are required but not checked on current code.
> 5) OAuth param_location isn't conforming to the spec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-854) OAuth miscellaneous bugs
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Chabot resolved SHINDIG-854.
----------------------------------
Resolution: Fixed
Assignee: Chris Chabot
patch looks good to me, i'll commit it once svn comes back to life :)
> OAuth miscellaneous bugs
> ------------------------
>
> Key: SHINDIG-854
> URL: https://issues.apache.org/jira/browse/SHINDIG-854
> Project: Shindig
> Issue Type: Improvement
> Components: Gadget Rendering Server (PHP)
> Affects Versions: trunk
> Reporter: Eiji Kitamura
> Assignee: Chris Chabot
> Priority: Trivial
> Fix For: trunk
>
> Attachments: OAuthFix.patch
>
>
> 1) OAuth/Service needs to have "name" attribute. Current implementation isn't complaining.
> 2) According to XSD, each url for OAuthServices (request, authorization, access) isn't mandatory. Current implementation is assuming they are existing.
> 3) parseEndPoint had better trim its paramers.
> 4) Some parameters (OAuth/Service@name, OAuth/Service/Request@url, OAuth/Service/Access@url, OAuth/Service/Authorization@url) are required but not checked on current code.
> 5) OAuth param_location isn't conforming to the spec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-854) OAuth miscellaneous bugs
Posted by "Eiji Kitamura (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eiji Kitamura updated SHINDIG-854:
----------------------------------
Attachment: OAuthFix.patch
Attached is a patch to fix all issues described in this ticket.
> OAuth miscellaneous bugs
> ------------------------
>
> Key: SHINDIG-854
> URL: https://issues.apache.org/jira/browse/SHINDIG-854
> Project: Shindig
> Issue Type: Improvement
> Components: Gadget Rendering Server (PHP)
> Affects Versions: trunk
> Reporter: Eiji Kitamura
> Priority: Trivial
> Fix For: trunk
>
> Attachments: OAuthFix.patch
>
>
> 1) OAuth/Service needs to have "name" attribute. Current implementation isn't complaining.
> 2) According to XSD, each url for OAuthServices (request, authorization, access) isn't mandatory. Current implementation is assuming they are existing.
> 3) parseEndPoint had better trim its paramers.
> 4) Some parameters (OAuth/Service@name, OAuth/Service/Request@url, OAuth/Service/Access@url, OAuth/Service/Authorization@url) are required but not checked on current code.
> 5) OAuth param_location isn't conforming to the spec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-854) OAuth miscellaneous bugs
Posted by "Yoichiro Tanaka (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663703#action_12663703 ]
Yoichiro Tanaka commented on SHINDIG-854:
-----------------------------------------
I think that OAuth/Service@name can be omitted in gadget xml file. When the name attribute is ommited, SERVICE_NAME can be omitted at calling makeRequest() function, too.
> OAuth miscellaneous bugs
> ------------------------
>
> Key: SHINDIG-854
> URL: https://issues.apache.org/jira/browse/SHINDIG-854
> Project: Shindig
> Issue Type: Improvement
> Components: Gadget Rendering Server (PHP)
> Affects Versions: trunk
> Reporter: Eiji Kitamura
> Priority: Trivial
> Fix For: trunk
>
> Attachments: OAuthFix.patch
>
>
> 1) OAuth/Service needs to have "name" attribute. Current implementation isn't complaining.
> 2) According to XSD, each url for OAuthServices (request, authorization, access) isn't mandatory. Current implementation is assuming they are existing.
> 3) parseEndPoint had better trim its paramers.
> 4) Some parameters (OAuth/Service@name, OAuth/Service/Request@url, OAuth/Service/Access@url, OAuth/Service/Authorization@url) are required but not checked on current code.
> 5) OAuth param_location isn't conforming to the spec.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.