You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2021/07/23 10:18:36 UTC
[GitHub] [cordova-plugin-file-transfer] erisu opened a new pull request #307: feat!: remove deprecated whitelist usage
erisu opened a new pull request #307:
URL: https://github.com/apache/cordova-plugin-file-transfer/pull/307
### Platforms affected
Android
### Motivation and Context
Build is failing in Cordova-Android 10.
fixes: #306
### Description
The `Whitelist` import can be removed.
The `getWhitelist` method was removed a long time ago. The `getWhitelist` method was related to the commented statement:
> This code exists for compatibility between 3.x and 4.x versions of Cordova.
The `AllowList` which was integrated into the core of **cordova-android** is still being loaded as if it was a plugin so there for the next if block should still work as usual to fetch the `shouldAllowRequest` value.
```java
if (shouldAllowRequest == null) {
try {
Method gpm = webView.getClass().getMethod("getPluginManager");
PluginManager pm = (PluginManager)gpm.invoke(webView);
Method san = pm.getClass().getMethod("shouldAllowRequest", String.class);
shouldAllowRequest = (Boolean)san.invoke(pm, source);
} catch (NoSuchMethodException e) {
} catch (IllegalAccessException e) {
} catch (InvocationTargetException e) {
}
}
```
Additionally, since there hasn't been a release since the undeprecation, it should be safe to say that the next release will be major and removing this old code is acceptable.
### Testing
- `cordova build`: build now passes
If anyone wants to confirm the `shouldAllowRequest` functionality continues to work as expected with their app, that would be appreciated.
### Checklist
- [x] I've run the tests to see all new and existing tests pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-file-transfer] growthengineering commented on pull request #307: feat!: remove deprecated whitelist usage
Posted by GitBox <gi...@apache.org>.
growthengineering commented on pull request #307:
URL: https://github.com/apache/cordova-plugin-file-transfer/pull/307#issuecomment-995850606
Its a problem! This needs to be fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-file-transfer] brunoalex commented on pull request #307: feat!: remove deprecated whitelist usage
Posted by GitBox <gi...@apache.org>.
brunoalex commented on pull request #307:
URL: https://github.com/apache/cordova-plugin-file-transfer/pull/307#issuecomment-974034630
realy need this fixed please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-file-transfer] gwhenne commented on pull request #307: feat!: remove deprecated whitelist usage
Posted by GitBox <gi...@apache.org>.
gwhenne commented on pull request #307:
URL: https://github.com/apache/cordova-plugin-file-transfer/pull/307#issuecomment-1006857144
This needs to be fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-file-transfer] bftcntyapps commented on pull request #307: feat!: remove deprecated whitelist usage
Posted by GitBox <gi...@apache.org>.
bftcntyapps commented on pull request #307:
URL: https://github.com/apache/cordova-plugin-file-transfer/pull/307#issuecomment-965156969
This is not found in the latest version of this plugin and is failing on Android API 30 using Ionic Appflow. Will this be fixed soon?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-file-transfer] erisu merged pull request #307: feat!: remove deprecated whitelist usage
Posted by GitBox <gi...@apache.org>.
erisu merged pull request #307:
URL: https://github.com/apache/cordova-plugin-file-transfer/pull/307
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org