[GitHub] [airflow] potiuk commented on a change in pull request #20263: rewrite opsgenie alert hook with official python sdk, related issue #18641

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #20263:
URL: https://github.com/apache/airflow/pull/20263#discussion_r772532401



##########
File path: UPDATING.md
##########
@@ -2089,6 +2089,10 @@ Remove unnecessary parameter ``open`` in PostgresHook function ``copy_expert`` f
 
 Change parameter name from ``visibleTo`` to ``visible_to`` in OpsgenieAlertOperator for pylint compatible
 
+`OpsgenieAlertHook` constructor does not take additional arguments or keyword arguments anymore.
+Changed the return type of `OpsgenieAlertHook.get_conn` to return a `opsgenie_sdk.AlertApi` object instead of a `requests.Session` object.
+Changed the return type of `OpsgenieAlertHook.execute` to return a `opsgenie_sdk.SuccessResponse` object instead of a `Any` type.
+

Review comment:
       Yeah. Moving to Opsgenie changelog at the top is best. Not all of it is generated automatically, only list of issues so you can move the comments to the top of the changelog - and I will add the right version after.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org