You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by re...@apache.org on 2023/10/28 02:35:28 UTC

(flink-connector-mongodb) branch main updated: [hotfix][connectors/mongodb] Fix typo and optimize log

This is an automated email from the ASF dual-hosted git repository.

renqs pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/flink-connector-mongodb.git


The following commit(s) were added to refs/heads/main by this push:
     new c098c93  [hotfix][connectors/mongodb] Fix typo and optimize log
c098c93 is described below

commit c098c93a2b80108bd57240b50cbec14cb2d712ef
Author: Jiabao Sun <ji...@xtransfer.cn>
AuthorDate: Tue Oct 10 19:28:24 2023 +0800

    [hotfix][connectors/mongodb] Fix typo and optimize log
---
 .../reader/split/MongoScanSourceSplitReader.java     |  4 ++--
 .../source/reader/split/MongoSourceSplitReader.java  |  2 +-
 .../mongodb/source/split/MongoScanSourceSplit.java   | 20 ++++++++++++++++++++
 .../connector/mongodb/source/MongoSourceITCase.java  |  2 +-
 4 files changed, 24 insertions(+), 4 deletions(-)

diff --git a/flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/source/reader/split/MongoScanSourceSplitReader.java b/flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/source/reader/split/MongoScanSourceSplitReader.java
index 134fe73..e521c91 100644
--- a/flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/source/reader/split/MongoScanSourceSplitReader.java
+++ b/flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/source/reader/split/MongoScanSourceSplitReader.java
@@ -46,7 +46,7 @@ import java.util.List;
 
 import static org.apache.flink.connector.mongodb.common.utils.MongoUtils.project;
 
-/** An split reader implements {@link SplitReader} for {@link MongoScanSourceSplit}. */
+/** A split reader implements {@link SplitReader} for {@link MongoScanSourceSplit}. */
 @Internal
 public class MongoScanSourceSplitReader implements MongoSourceSplitReader<MongoSourceSplit> {
 
@@ -163,7 +163,7 @@ public class MongoScanSourceSplitReader implements MongoSourceSplitReader<MongoS
 
     private MongoCursor<BsonDocument> getOrCreateCursor() {
         if (currentCursor == null) {
-            LOG.debug("Opened cursor for partitionId: {}", currentSplit);
+            LOG.debug("Opened cursor for split: {}", currentSplit);
             mongoClient = MongoClients.create(connectionOptions.getUri());
 
             // Using MongoDB's cursor.min() and cursor.max() to limit an index bound.
diff --git a/flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/source/reader/split/MongoSourceSplitReader.java b/flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/source/reader/split/MongoSourceSplitReader.java
index 1a88adf..eae1464 100644
--- a/flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/source/reader/split/MongoSourceSplitReader.java
+++ b/flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/source/reader/split/MongoSourceSplitReader.java
@@ -24,7 +24,7 @@ import org.apache.flink.connector.mongodb.source.split.MongoSourceSplit;
 import org.bson.BsonDocument;
 
 /**
- * An split reader implements {@link SplitReader} for {@link MongoSourceSplit}.
+ * A split reader implements {@link SplitReader} for {@link MongoSourceSplit}.
  *
  * @param <T> Mongo source split.
  */
diff --git a/flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/source/split/MongoScanSourceSplit.java b/flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/source/split/MongoScanSourceSplit.java
index c756074..e515975 100644
--- a/flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/source/split/MongoScanSourceSplit.java
+++ b/flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/source/split/MongoScanSourceSplit.java
@@ -117,4 +117,24 @@ public class MongoScanSourceSplit extends MongoSourceSplit {
     public int hashCode() {
         return Objects.hash(super.hashCode(), database, collection, min, max, hint, offset);
     }
+
+    @Override
+    public String toString() {
+        return "MongoScanSourceSplit {"
+                + " splitId="
+                + splitId
+                + ", database="
+                + database
+                + ", collection="
+                + collection
+                + ", min="
+                + min
+                + ", max="
+                + max
+                + ", hint="
+                + hint
+                + ", offset="
+                + offset
+                + " }";
+    }
 }
diff --git a/flink-connector-mongodb/src/test/java/org/apache/flink/connector/mongodb/source/MongoSourceITCase.java b/flink-connector-mongodb/src/test/java/org/apache/flink/connector/mongodb/source/MongoSourceITCase.java
index e577006..0578c57 100644
--- a/flink-connector-mongodb/src/test/java/org/apache/flink/connector/mongodb/source/MongoSourceITCase.java
+++ b/flink-connector-mongodb/src/test/java/org/apache/flink/connector/mongodb/source/MongoSourceITCase.java
@@ -74,7 +74,7 @@ import static org.apache.flink.connector.mongodb.common.utils.MongoConstants.DEF
 import static org.apache.flink.connector.mongodb.common.utils.MongoConstants.ID_FIELD;
 import static org.assertj.core.api.Assertions.assertThat;
 
-/** IT cases for using Mongo Sink. */
+/** IT cases for using Mongo Source. */
 @Testcontainers
 public class MongoSourceITCase {