You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by hanm <gi...@git.apache.org> on 2018/09/28 00:03:00 UTC

[GitHub] zookeeper pull request #184: ZOOKEEPER-236: SSL Support for Atomic Broadcast...

Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/184#discussion_r220732624
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
    @@ -632,37 +639,49 @@ synchronized private boolean connectOne(long sid, InetSocketAddress electionAddr
     
             Socket sock = null;
             try {
    -            LOG.debug("Opening channel to server " + sid);
    -            sock = new Socket();
    -            setSockOpts(sock);
    -            sock.connect(electionAddr, cnxTO);
    -            LOG.debug("Connected to server " + sid);
    +             LOG.debug("Opening channel to server " + sid);
    --- End diff --
    
    nit: indentations on this line and the following lines


---