You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "smitajoshi12 (via GitHub)" <gi...@apache.org> on 2023/10/31 08:10:42 UTC
[PR] HDDS-9085. Recon Directories Pending for Deletion Inside OMDB Insight [ozone]
smitajoshi12 opened a new pull request, #5521:
URL: https://github.com/apache/ozone/pull/5521
## What changes were proposed in this pull request?
New Enhancement on Recon Directories Pending for Deletion Inside OMDB Insight
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9085
## How was this patch tested?
Manually
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9085. Recon Directories Pending for Deletion Inside OMDB Insight [ozone]
Posted by "smitajoshi12 (via GitHub)" <gi...@apache.org>.
smitajoshi12 commented on code in PR #5521:
URL: https://github.com/apache/ozone/pull/5521#discussion_r1390833603
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/insights/om/om.tsx:
##########
@@ -776,6 +820,66 @@ export class Om extends React.Component<Record<string, object>, IOmdbInsightsSta
});
};
+ // Pending Delete Directories
+ fetchDeletePendingDir = (limit: number, prevKeyDirDelete: string) => {
+ this.setState({
+ loading: true,
+ nextClickable: true,
+ prevClickable: true
+ });
+
+ //Cancel any previous pending request
+ cancelRequests([
+ cancelMismatchedEndpointSignal,
+ cancelOpenKeysSignal,
+ cancelDeletePendingSignal,
+ cancelDeletedKeysSignal,
+ cancelRowExpandSignal,
+ cancelDeletedPendingDirSignal
+ ]);
+
+ let deletePendingDirEndpoint;
+ if (prevKeyDirDelete === "" || prevKeyDirDelete === undefined ) {
+ deletePendingDirEndpoint = `/api/v1/keys/deletePending/dirs?limit=${limit}`;
+ }
+ else {
+ deletePendingDirEndpoint = `/api/v1/keys/deletePending/dirs?limit=${limit}&prevKey=${prevKeyDirDelete}`;
+ }
+
+ const { request, controller } = AxiosGetHelper(deletePendingDirEndpoint, cancelDeletedPendingDirSignal);
+ cancelDeletedPendingDirSignal = controller
+ request.then(deletePendingDirResponse => {
+ const deletedDirInfo = deletePendingDirResponse && deletePendingDirResponse.data && deletePendingDirResponse.data.deletedDirInfo;
+ if (deletePendingDirResponse && deletePendingDirResponse.data && deletePendingDirResponse.data.lastKey === "") {
+ //last key of api is empty may be last record no further records
+ dirPendingPrevList =[""];
+ this.setState({
+ loading: false,
+ nextClickable: false,
+ pendingDeleteDirDataSource: deletedDirInfo
+ })
+ }
+ else {
+ if (this.state.prevKeyDirDelete === "" ||this.state.prevKeyDirDelete === undefined ) {
Review Comment:
@devmadhuu
Completed Changes and pushed in recent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9085. Recon Directories Pending for Deletion Inside OMDB Insight [ozone]
Posted by "smitajoshi12 (via GitHub)" <gi...@apache.org>.
smitajoshi12 commented on code in PR #5521:
URL: https://github.com/apache/ozone/pull/5521#discussion_r1526073591
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/api/db.json:
##########
@@ -6686,5 +6686,73 @@
]
}
]
+ },
+ "dirdeletePending": {
+ "lastKey": "dir11",
Review Comment:
@dombizita Pushed changes in latest commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9085. Recon Directories Pending for Deletion Inside OMDB Insight [ozone]
Posted by "smitajoshi12 (via GitHub)" <gi...@apache.org>.
smitajoshi12 commented on code in PR #5521:
URL: https://github.com/apache/ozone/pull/5521#discussion_r1461889715
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/insights/om/om.tsx:
##########
@@ -777,6 +820,66 @@ export class Om extends React.Component<Record<string, object>, IOmdbInsightsSta
});
};
+ // Pending Delete Directories
+ fetchDeletePendingDir = (limit: number, prevKeyDirDelete: string) => {
+ this.setState({
+ loading: true,
+ nextClickable: true,
+ prevClickable: true
+ });
+
+ //Cancel any previous pending request
+ cancelRequests([
+ cancelMismatchedEndpointSignal,
+ cancelOpenKeysSignal,
+ cancelDeletePendingSignal,
+ cancelDeletedKeysSignal,
+ cancelRowExpandSignal,
+ cancelDeletedPendingDirSignal
+ ]);
+
+ let deletePendingDirEndpoint;
+ if (prevKeyDirDelete === "" || prevKeyDirDelete === undefined ) {
+ deletePendingDirEndpoint = `/api/v1/keys/deletePending/dirs?limit=${limit}`;
+ }
+ else {
+ deletePendingDirEndpoint = `/api/v1/keys/deletePending/dirs?limit=${limit}&prevKey=${prevKeyDirDelete}`;
+ }
+
+ const { request, controller } = AxiosGetHelper(deletePendingDirEndpoint, cancelDeletedPendingDirSignal);
+ cancelDeletedPendingDirSignal = controller
+ request.then(deletePendingDirResponse => {
+ const deletedDirInfo = deletePendingDirResponse && deletePendingDirResponse.data && deletePendingDirResponse.data.deletedDirInfo;
+ if (deletePendingDirResponse && deletePendingDirResponse.data && deletePendingDirResponse.data.lastKey === "") {
+ //last key of api is empty may be last record no further records
+ dirPendingPrevList =[""];
+ this.setState({
+ loading: false,
+ nextClickable: false,
+ pendingDeleteDirDataSource: deletedDirInfo
+ })
+ }
+ else {
+ if (this.state.prevKeyDirDelete === "" || this.state.prevKeyDirDelete === undefined ) {
Review Comment:
undefined and ! operators are slightly having difference as explained in above comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9085. Recon Directories Pending for Deletion Inside OMDB Insight [ozone]
Posted by "ArafatKhan2198 (via GitHub)" <gi...@apache.org>.
ArafatKhan2198 commented on PR #5521:
URL: https://github.com/apache/ozone/pull/5521#issuecomment-1907614313
Also have you tested it out with actual cluster data? or is it just from `db.json` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9085. Recon Directories Pending for Deletion Inside OMDB Insight [ozone]
Posted by "dombizita (via GitHub)" <gi...@apache.org>.
dombizita merged PR #5521:
URL: https://github.com/apache/ozone/pull/5521
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9085. Recon Directories Pending for Deletion Inside OMDB Insight [ozone]
Posted by "devmadhuu (via GitHub)" <gi...@apache.org>.
devmadhuu commented on code in PR #5521:
URL: https://github.com/apache/ozone/pull/5521#discussion_r1384380107
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/insights/om/om.tsx:
##########
@@ -459,6 +495,9 @@ export class Om extends React.Component<Record<string, object>, IOmdbInsightsSta
} else if (this.state.activeTab === '4') {
this.fetchDeletedKeys(this.state.DEFAULT_LIMIT, this.state.prevKeyDeleted);
}
+ else if (this.state.activeTab === '5') {
+ this.fetchDeletePendingDir(this.state.DEFAULT_LIMIT, this.state.prevKeyDirDelete);
Review Comment:
@smitajoshi12 thanks for working on this patch. Pls correct the formatting and indent.
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/insights/om/om.tsx:
##########
@@ -776,6 +820,66 @@ export class Om extends React.Component<Record<string, object>, IOmdbInsightsSta
});
};
+ // Pending Delete Directories
+ fetchDeletePendingDir = (limit: number, prevKeyDirDelete: string) => {
+ this.setState({
+ loading: true,
+ nextClickable: true,
+ prevClickable: true
+ });
+
+ //Cancel any previous pending request
+ cancelRequests([
+ cancelMismatchedEndpointSignal,
+ cancelOpenKeysSignal,
+ cancelDeletePendingSignal,
+ cancelDeletedKeysSignal,
+ cancelRowExpandSignal,
+ cancelDeletedPendingDirSignal
+ ]);
+
+ let deletePendingDirEndpoint;
+ if (prevKeyDirDelete === "" || prevKeyDirDelete === undefined ) {
+ deletePendingDirEndpoint = `/api/v1/keys/deletePending/dirs?limit=${limit}`;
+ }
+ else {
+ deletePendingDirEndpoint = `/api/v1/keys/deletePending/dirs?limit=${limit}&prevKey=${prevKeyDirDelete}`;
+ }
+
+ const { request, controller } = AxiosGetHelper(deletePendingDirEndpoint, cancelDeletedPendingDirSignal);
+ cancelDeletedPendingDirSignal = controller
+ request.then(deletePendingDirResponse => {
+ const deletedDirInfo = deletePendingDirResponse && deletePendingDirResponse.data && deletePendingDirResponse.data.deletedDirInfo;
+ if (deletePendingDirResponse && deletePendingDirResponse.data && deletePendingDirResponse.data.lastKey === "") {
+ //last key of api is empty may be last record no further records
+ dirPendingPrevList =[""];
+ this.setState({
+ loading: false,
+ nextClickable: false,
+ pendingDeleteDirDataSource: deletedDirInfo
+ })
+ }
+ else {
+ if (this.state.prevKeyDirDelete === "" ||this.state.prevKeyDirDelete === undefined ) {
Review Comment:
Add space after ||
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9085. Recon Directories Pending for Deletion Inside OMDB Insight [ozone]
Posted by "smitajoshi12 (via GitHub)" <gi...@apache.org>.
smitajoshi12 commented on code in PR #5521:
URL: https://github.com/apache/ozone/pull/5521#discussion_r1461889715
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/insights/om/om.tsx:
##########
@@ -777,6 +820,66 @@ export class Om extends React.Component<Record<string, object>, IOmdbInsightsSta
});
};
+ // Pending Delete Directories
+ fetchDeletePendingDir = (limit: number, prevKeyDirDelete: string) => {
+ this.setState({
+ loading: true,
+ nextClickable: true,
+ prevClickable: true
+ });
+
+ //Cancel any previous pending request
+ cancelRequests([
+ cancelMismatchedEndpointSignal,
+ cancelOpenKeysSignal,
+ cancelDeletePendingSignal,
+ cancelDeletedKeysSignal,
+ cancelRowExpandSignal,
+ cancelDeletedPendingDirSignal
+ ]);
+
+ let deletePendingDirEndpoint;
+ if (prevKeyDirDelete === "" || prevKeyDirDelete === undefined ) {
+ deletePendingDirEndpoint = `/api/v1/keys/deletePending/dirs?limit=${limit}`;
+ }
+ else {
+ deletePendingDirEndpoint = `/api/v1/keys/deletePending/dirs?limit=${limit}&prevKey=${prevKeyDirDelete}`;
+ }
+
+ const { request, controller } = AxiosGetHelper(deletePendingDirEndpoint, cancelDeletedPendingDirSignal);
+ cancelDeletedPendingDirSignal = controller
+ request.then(deletePendingDirResponse => {
+ const deletedDirInfo = deletePendingDirResponse && deletePendingDirResponse.data && deletePendingDirResponse.data.deletedDirInfo;
+ if (deletePendingDirResponse && deletePendingDirResponse.data && deletePendingDirResponse.data.lastKey === "") {
+ //last key of api is empty may be last record no further records
+ dirPendingPrevList =[""];
+ this.setState({
+ loading: false,
+ nextClickable: false,
+ pendingDeleteDirDataSource: deletedDirInfo
+ })
+ }
+ else {
+ if (this.state.prevKeyDirDelete === "" || this.state.prevKeyDirDelete === undefined ) {
Review Comment:
Will change once https://github.com/apache/ozone/pull/5658 this PR gets merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9085. Recon Directories Pending for Deletion Inside OMDB Insight [ozone]
Posted by "ArafatKhan2198 (via GitHub)" <gi...@apache.org>.
ArafatKhan2198 commented on code in PR #5521:
URL: https://github.com/apache/ozone/pull/5521#discussion_r1461681745
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/insights/om/om.tsx:
##########
@@ -777,6 +820,66 @@ export class Om extends React.Component<Record<string, object>, IOmdbInsightsSta
});
};
+ // Pending Delete Directories
+ fetchDeletePendingDir = (limit: number, prevKeyDirDelete: string) => {
+ this.setState({
+ loading: true,
+ nextClickable: true,
+ prevClickable: true
+ });
+
+ //Cancel any previous pending request
+ cancelRequests([
+ cancelMismatchedEndpointSignal,
+ cancelOpenKeysSignal,
+ cancelDeletePendingSignal,
+ cancelDeletedKeysSignal,
+ cancelRowExpandSignal,
+ cancelDeletedPendingDirSignal
+ ]);
+
+ let deletePendingDirEndpoint;
+ if (prevKeyDirDelete === "" || prevKeyDirDelete === undefined ) {
+ deletePendingDirEndpoint = `/api/v1/keys/deletePending/dirs?limit=${limit}`;
+ }
+ else {
+ deletePendingDirEndpoint = `/api/v1/keys/deletePending/dirs?limit=${limit}&prevKey=${prevKeyDirDelete}`;
Review Comment:
Use the constant DELETE_PENDING_DIR_ENDPOINT here as well.
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/insights/om/om.tsx:
##########
@@ -777,6 +820,66 @@ export class Om extends React.Component<Record<string, object>, IOmdbInsightsSta
});
};
+ // Pending Delete Directories
+ fetchDeletePendingDir = (limit: number, prevKeyDirDelete: string) => {
+ this.setState({
+ loading: true,
+ nextClickable: true,
+ prevClickable: true
+ });
+
+ //Cancel any previous pending request
+ cancelRequests([
+ cancelMismatchedEndpointSignal,
+ cancelOpenKeysSignal,
+ cancelDeletePendingSignal,
+ cancelDeletedKeysSignal,
+ cancelRowExpandSignal,
+ cancelDeletedPendingDirSignal
+ ]);
+
+ let deletePendingDirEndpoint;
+ if (prevKeyDirDelete === "" || prevKeyDirDelete === undefined ) {
+ deletePendingDirEndpoint = `/api/v1/keys/deletePending/dirs?limit=${limit}`;
Review Comment:
We can wrap it into a constant and use it in different places.
```
const DELETE_PENDING_DIR_ENDPOINT = "/api/v1/keys/deletePending/dirs";
```
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/insights/om/om.tsx:
##########
@@ -777,6 +820,66 @@ export class Om extends React.Component<Record<string, object>, IOmdbInsightsSta
});
};
+ // Pending Delete Directories
+ fetchDeletePendingDir = (limit: number, prevKeyDirDelete: string) => {
+ this.setState({
+ loading: true,
+ nextClickable: true,
+ prevClickable: true
+ });
+
+ //Cancel any previous pending request
+ cancelRequests([
+ cancelMismatchedEndpointSignal,
+ cancelOpenKeysSignal,
+ cancelDeletePendingSignal,
+ cancelDeletedKeysSignal,
+ cancelRowExpandSignal,
+ cancelDeletedPendingDirSignal
+ ]);
+
+ let deletePendingDirEndpoint;
+ if (prevKeyDirDelete === "" || prevKeyDirDelete === undefined ) {
+ deletePendingDirEndpoint = `/api/v1/keys/deletePending/dirs?limit=${limit}`;
+ }
+ else {
+ deletePendingDirEndpoint = `/api/v1/keys/deletePending/dirs?limit=${limit}&prevKey=${prevKeyDirDelete}`;
+ }
+
+ const { request, controller } = AxiosGetHelper(deletePendingDirEndpoint, cancelDeletedPendingDirSignal);
+ cancelDeletedPendingDirSignal = controller
+ request.then(deletePendingDirResponse => {
+ const deletedDirInfo = deletePendingDirResponse && deletePendingDirResponse.data && deletePendingDirResponse.data.deletedDirInfo;
+ if (deletePendingDirResponse && deletePendingDirResponse.data && deletePendingDirResponse.data.lastKey === "") {
+ //last key of api is empty may be last record no further records
+ dirPendingPrevList =[""];
+ this.setState({
+ loading: false,
+ nextClickable: false,
+ pendingDeleteDirDataSource: deletedDirInfo
+ })
+ }
+ else {
+ if (this.state.prevKeyDirDelete === "" || this.state.prevKeyDirDelete === undefined ) {
+ this.setState({ prevClickable: false })
+ }
+ if (dirPendingPrevList.includes(deletePendingDirResponse.data.lastKey) === false) {
+ dirPendingPrevList.push(deletePendingDirResponse.data.lastKey);
+ }
Review Comment:
```suggestion
if (!dirPendingPrevList.includes(lastKey)) {
dirPendingPrevList.push(lastKey);
}
```
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/insights/om/om.tsx:
##########
@@ -777,6 +820,66 @@ export class Om extends React.Component<Record<string, object>, IOmdbInsightsSta
});
};
+ // Pending Delete Directories
+ fetchDeletePendingDir = (limit: number, prevKeyDirDelete: string) => {
+ this.setState({
+ loading: true,
+ nextClickable: true,
+ prevClickable: true
+ });
+
+ //Cancel any previous pending request
+ cancelRequests([
+ cancelMismatchedEndpointSignal,
+ cancelOpenKeysSignal,
+ cancelDeletePendingSignal,
+ cancelDeletedKeysSignal,
+ cancelRowExpandSignal,
+ cancelDeletedPendingDirSignal
+ ]);
+
+ let deletePendingDirEndpoint;
+ if (prevKeyDirDelete === "" || prevKeyDirDelete === undefined ) {
+ deletePendingDirEndpoint = `/api/v1/keys/deletePending/dirs?limit=${limit}`;
+ }
+ else {
+ deletePendingDirEndpoint = `/api/v1/keys/deletePending/dirs?limit=${limit}&prevKey=${prevKeyDirDelete}`;
+ }
+
+ const { request, controller } = AxiosGetHelper(deletePendingDirEndpoint, cancelDeletedPendingDirSignal);
+ cancelDeletedPendingDirSignal = controller
+ request.then(deletePendingDirResponse => {
+ const deletedDirInfo = deletePendingDirResponse && deletePendingDirResponse.data && deletePendingDirResponse.data.deletedDirInfo;
Review Comment:
Store the value of `deletePendingDirResponse.data.lastKey` into another constant called `lastKey` and use it everywhere instead of accessing it again and again from the the response.
```
const lastKey = deletePendingDirResponse?.data?.lastKey || "";
```
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/insights/om/om.tsx:
##########
@@ -777,6 +820,66 @@ export class Om extends React.Component<Record<string, object>, IOmdbInsightsSta
});
};
+ // Pending Delete Directories
+ fetchDeletePendingDir = (limit: number, prevKeyDirDelete: string) => {
Review Comment:
Can you please change the name of the variable `prevKeyDirDelete` to `prevKeyDeletedDirectory`
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/insights/om/om.tsx:
##########
@@ -777,6 +820,66 @@ export class Om extends React.Component<Record<string, object>, IOmdbInsightsSta
});
};
+ // Pending Delete Directories
+ fetchDeletePendingDir = (limit: number, prevKeyDirDelete: string) => {
+ this.setState({
+ loading: true,
+ nextClickable: true,
+ prevClickable: true
+ });
+
+ //Cancel any previous pending request
+ cancelRequests([
+ cancelMismatchedEndpointSignal,
+ cancelOpenKeysSignal,
+ cancelDeletePendingSignal,
+ cancelDeletedKeysSignal,
+ cancelRowExpandSignal,
+ cancelDeletedPendingDirSignal
+ ]);
+
+ let deletePendingDirEndpoint;
+ if (prevKeyDirDelete === "" || prevKeyDirDelete === undefined ) {
Review Comment:
Replace `prevKeyDirDelete === ""` with `!previousKeyForDeletion`
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/insights/om/om.tsx:
##########
@@ -777,6 +820,66 @@ export class Om extends React.Component<Record<string, object>, IOmdbInsightsSta
});
};
+ // Pending Delete Directories
+ fetchDeletePendingDir = (limit: number, prevKeyDirDelete: string) => {
+ this.setState({
+ loading: true,
+ nextClickable: true,
+ prevClickable: true
+ });
+
+ //Cancel any previous pending request
+ cancelRequests([
+ cancelMismatchedEndpointSignal,
+ cancelOpenKeysSignal,
+ cancelDeletePendingSignal,
+ cancelDeletedKeysSignal,
+ cancelRowExpandSignal,
+ cancelDeletedPendingDirSignal
+ ]);
+
+ let deletePendingDirEndpoint;
+ if (prevKeyDirDelete === "" || prevKeyDirDelete === undefined ) {
+ deletePendingDirEndpoint = `/api/v1/keys/deletePending/dirs?limit=${limit}`;
+ }
+ else {
+ deletePendingDirEndpoint = `/api/v1/keys/deletePending/dirs?limit=${limit}&prevKey=${prevKeyDirDelete}`;
+ }
+
+ const { request, controller } = AxiosGetHelper(deletePendingDirEndpoint, cancelDeletedPendingDirSignal);
+ cancelDeletedPendingDirSignal = controller
+ request.then(deletePendingDirResponse => {
+ const deletedDirInfo = deletePendingDirResponse && deletePendingDirResponse.data && deletePendingDirResponse.data.deletedDirInfo;
+ if (deletePendingDirResponse && deletePendingDirResponse.data && deletePendingDirResponse.data.lastKey === "") {
+ //last key of api is empty may be last record no further records
+ dirPendingPrevList =[""];
+ this.setState({
+ loading: false,
+ nextClickable: false,
+ pendingDeleteDirDataSource: deletedDirInfo
+ })
+ }
+ else {
+ if (this.state.prevKeyDirDelete === "" || this.state.prevKeyDirDelete === undefined ) {
Review Comment:
```suggestion
if (!this.state.prevKeyDirDelete) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9085. Recon Directories Pending for Deletion Inside OMDB Insight [ozone]
Posted by "smitajoshi12 (via GitHub)" <gi...@apache.org>.
smitajoshi12 commented on code in PR #5521:
URL: https://github.com/apache/ozone/pull/5521#discussion_r1461885273
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/insights/om/om.tsx:
##########
@@ -777,6 +820,66 @@ export class Om extends React.Component<Record<string, object>, IOmdbInsightsSta
});
};
+ // Pending Delete Directories
+ fetchDeletePendingDir = (limit: number, prevKeyDirDelete: string) => {
+ this.setState({
+ loading: true,
+ nextClickable: true,
+ prevClickable: true
+ });
+
+ //Cancel any previous pending request
+ cancelRequests([
+ cancelMismatchedEndpointSignal,
+ cancelOpenKeysSignal,
+ cancelDeletePendingSignal,
+ cancelDeletedKeysSignal,
+ cancelRowExpandSignal,
+ cancelDeletedPendingDirSignal
+ ]);
+
+ let deletePendingDirEndpoint;
+ if (prevKeyDirDelete === "" || prevKeyDirDelete === undefined ) {
+ deletePendingDirEndpoint = `/api/v1/keys/deletePending/dirs?limit=${limit}`;
Review Comment:
Done Change in latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9085. Recon Directories Pending for Deletion Inside OMDB Insight [ozone]
Posted by "devmadhuu (via GitHub)" <gi...@apache.org>.
devmadhuu commented on PR #5521:
URL: https://github.com/apache/ozone/pull/5521#issuecomment-1903352785
@ArafatKhan2198 @smitajoshi12 , I think instead of showing rocks DB key to user which is not useful for end user, we should display the complete path of directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9085. Recon Directories Pending for Deletion Inside OMDB Insight [ozone]
Posted by "smitajoshi12 (via GitHub)" <gi...@apache.org>.
smitajoshi12 commented on code in PR #5521:
URL: https://github.com/apache/ozone/pull/5521#discussion_r1526069628
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/insights/om/om.tsx:
##########
@@ -1038,7 +1177,7 @@ export class Om extends React.Component<Record<string, object>, IOmdbInsightsSta
};
render() {
- const { mismatchDataSource, loading, openKeysDataSource, pendingDeleteKeyDataSource, deletedContainerKeysDataSource } = this.state;
+ const { mismatchDataSource, loading, openKeysDataSource, pendingDeleteKeyDataSource, pendingDeleteDirDataSource,deletedContainerKeysDataSource } = this.state;
Review Comment:
@Zita It is resolved in Mege Commit
![Uploading image.png…]()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9085. Recon Directories Pending for Deletion Inside OMDB Insight [ozone]
Posted by "aswinshakil (via GitHub)" <gi...@apache.org>.
aswinshakil commented on PR #5521:
URL: https://github.com/apache/ozone/pull/5521#issuecomment-1795594007
cc: @devmadhuu @dombizita
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9085. Recon Directories Pending for Deletion Inside OMDB Insight [ozone]
Posted by "smitajoshi12 (via GitHub)" <gi...@apache.org>.
smitajoshi12 commented on code in PR #5521:
URL: https://github.com/apache/ozone/pull/5521#discussion_r1390837626
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/insights/om/om.tsx:
##########
@@ -459,6 +495,9 @@ export class Om extends React.Component<Record<string, object>, IOmdbInsightsSta
} else if (this.state.activeTab === '4') {
this.fetchDeletedKeys(this.state.DEFAULT_LIMIT, this.state.prevKeyDeleted);
}
+ else if (this.state.activeTab === '5') {
+ this.fetchDeletePendingDir(this.state.DEFAULT_LIMIT, this.state.prevKeyDirDelete);
Review Comment:
Completed Changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9085. Recon Directories Pending for Deletion Inside OMDB Insight [ozone]
Posted by "smitajoshi12 (via GitHub)" <gi...@apache.org>.
smitajoshi12 commented on code in PR #5521:
URL: https://github.com/apache/ozone/pull/5521#discussion_r1461863286
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/insights/om/om.tsx:
##########
@@ -777,6 +820,66 @@ export class Om extends React.Component<Record<string, object>, IOmdbInsightsSta
});
};
+ // Pending Delete Directories
+ fetchDeletePendingDir = (limit: number, prevKeyDirDelete: string) => {
+ this.setState({
+ loading: true,
+ nextClickable: true,
+ prevClickable: true
+ });
+
+ //Cancel any previous pending request
+ cancelRequests([
+ cancelMismatchedEndpointSignal,
+ cancelOpenKeysSignal,
+ cancelDeletePendingSignal,
+ cancelDeletedKeysSignal,
+ cancelRowExpandSignal,
+ cancelDeletedPendingDirSignal
+ ]);
+
+ let deletePendingDirEndpoint;
+ if (prevKeyDirDelete === "" || prevKeyDirDelete === undefined ) {
Review Comment:
@ArafatKhan2198
There is slight difference between undefined and ! operator
For Example
function test(t) {
if (!t) {
return 'Undefined value!';
}
return t;
}
let x=0;
console.log(test(x));
Output:- Undefined value!
For this scenario ! operator is not properly checking our conditions. We have to check empty or undefined values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9085. Recon Directories Pending for Deletion Inside OMDB Insight [ozone]
Posted by "dombizita (via GitHub)" <gi...@apache.org>.
dombizita commented on PR #5521:
URL: https://github.com/apache/ozone/pull/5521#issuecomment-2009573972
Thanks for working on this @smitajoshi12! Thanks for the review @ArafatKhan2198 @devmadhuu!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9085. Recon Directories Pending for Deletion Inside OMDB Insight [ozone]
Posted by "smitajoshi12 (via GitHub)" <gi...@apache.org>.
smitajoshi12 commented on PR #5521:
URL: https://github.com/apache/ozone/pull/5521#issuecomment-1907812052
> Also have you tested it out with actual cluster data? or is it just from `db.json` ?
Actual Cluster Data
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9085. Recon Directories Pending for Deletion Inside OMDB Insight [ozone]
Posted by "smitajoshi12 (via GitHub)" <gi...@apache.org>.
smitajoshi12 commented on code in PR #5521:
URL: https://github.com/apache/ozone/pull/5521#discussion_r1461888286
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/insights/om/om.tsx:
##########
@@ -777,6 +820,66 @@ export class Om extends React.Component<Record<string, object>, IOmdbInsightsSta
});
};
+ // Pending Delete Directories
+ fetchDeletePendingDir = (limit: number, prevKeyDirDelete: string) => {
+ this.setState({
+ loading: true,
+ nextClickable: true,
+ prevClickable: true
+ });
+
+ //Cancel any previous pending request
+ cancelRequests([
+ cancelMismatchedEndpointSignal,
+ cancelOpenKeysSignal,
+ cancelDeletePendingSignal,
+ cancelDeletedKeysSignal,
+ cancelRowExpandSignal,
+ cancelDeletedPendingDirSignal
+ ]);
+
+ let deletePendingDirEndpoint;
+ if (prevKeyDirDelete === "" || prevKeyDirDelete === undefined ) {
+ deletePendingDirEndpoint = `/api/v1/keys/deletePending/dirs?limit=${limit}`;
+ }
+ else {
+ deletePendingDirEndpoint = `/api/v1/keys/deletePending/dirs?limit=${limit}&prevKey=${prevKeyDirDelete}`;
+ }
+
+ const { request, controller } = AxiosGetHelper(deletePendingDirEndpoint, cancelDeletedPendingDirSignal);
+ cancelDeletedPendingDirSignal = controller
+ request.then(deletePendingDirResponse => {
+ const deletedDirInfo = deletePendingDirResponse && deletePendingDirResponse.data && deletePendingDirResponse.data.deletedDirInfo;
Review Comment:
deletePendingDirResponse?.data?.lastKey is advance and babel is not supporting but need to change logic once this pr gets merged. I will do once PR got merged need to change pagination and other logic when we are going on last page.
https://github.com/apache/ozone/pull/5658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9085. Recon Directories Pending for Deletion Inside OMDB Insight [ozone]
Posted by "smitajoshi12 (via GitHub)" <gi...@apache.org>.
smitajoshi12 commented on PR #5521:
URL: https://github.com/apache/ozone/pull/5521#issuecomment-1903573960
> {
> "lastKey": "/-4611686018427388160/-9223372036854775552/-9223372036854767358/240122081700/-9223372036854767357",
> "replicatedDataSize": 0,
> "unreplicatedDataSize": 103734,
> "deletedDirInfo": [
> {
> "**key": "/-4611686018427388160/-9223372036854775552/-9223372036854767358/240122081700/-9223372036854767357"**,
> "**path": ".Trash/hadoop/240122081700**",
> "inStateSince": 1705911362730,
> "size": 103734,
> "replicatedSize": 0,
> "replicationInfo": {
> "replicationFactor": "THREE",
> "requiredNodes": 3,
> "replicationType": "RATIS"
> }
> }
> ],
> "status": "OK"
> }
@devmadhuu
Hi Devesh we are showing key and path both variables but for complete path do we need to add any variable in JSON Response apart from key and Path.
{
"lastKey": "/-4611686018427388160/-9223372036854775552/-9223372036854767358/240122081700/-9223372036854767357",
"replicatedDataSize": 0,
"unreplicatedDataSize": 103734,
"deletedDirInfo": [
{
"key": "/-4611686018427388160/-9223372036854775552/-9223372036854767358/240122081700/-9223372036854767357",
"path": ".Trash/hadoop/240122081700",
"inStateSince": 1705911362730,
"size": 103734,
"replicatedSize": 0,
"replicationInfo": {
"replicationFactor": "THREE",
"requiredNodes": 3,
"replicationType": "RATIS"
}
}
],
"status": "OK"
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9085. Recon Directories Pending for Deletion Inside OMDB Insight [ozone]
Posted by "smitajoshi12 (via GitHub)" <gi...@apache.org>.
smitajoshi12 commented on PR #5521:
URL: https://github.com/apache/ozone/pull/5521#issuecomment-1903568215
> @smitajoshi12 Can you update your screenshots with proper API response ? Not sure why replicated data size is zero for the directories pending for deletion ?
@devmadhuu Unless I delete content from Directories I could not delete directory so size may be zero while hitting command
ozone fs -rmdir directorypath
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9085. Recon Directories Pending for Deletion Inside OMDB Insight [ozone]
Posted by "dombizita (via GitHub)" <gi...@apache.org>.
dombizita commented on code in PR #5521:
URL: https://github.com/apache/ozone/pull/5521#discussion_r1384806875
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/insights/om/om.tsx:
##########
@@ -1038,7 +1177,7 @@ export class Om extends React.Component<Record<string, object>, IOmdbInsightsSta
};
render() {
- const { mismatchDataSource, loading, openKeysDataSource, pendingDeleteKeyDataSource, deletedContainerKeysDataSource } = this.state;
+ const { mismatchDataSource, loading, openKeysDataSource, pendingDeleteKeyDataSource, pendingDeleteDirDataSource,deletedContainerKeysDataSource } = this.state;
Review Comment:
```suggestion
const { mismatchDataSource, loading, openKeysDataSource, pendingDeleteKeyDataSource, pendingDeleteDirDataSource, deletedContainerKeysDataSource } = this.state;
```
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/api/db.json:
##########
@@ -6686,5 +6686,73 @@
]
}
]
+ },
+ "dirdeletePending": {
+ "lastKey": "dir11",
Review Comment:
I think this is not necessary.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9085. Recon Directories Pending for Deletion Inside OMDB Insight [ozone]
Posted by "ArafatKhan2198 (via GitHub)" <gi...@apache.org>.
ArafatKhan2198 commented on PR #5521:
URL: https://github.com/apache/ozone/pull/5521#issuecomment-1907613327
@smitajoshi12 thanks for the changes.
Please update the column name from "Key" to "Path" in the table. I think it will be more intuitive for users and reduce potential confusion.
<img width="1509" alt="image" src="https://github.com/apache/ozone/assets/98023601/6b218c1a-b8bb-48f5-9196-ba7bb0422b99">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9085. Recon Directories Pending for Deletion Inside OMDB Insight [ozone]
Posted by "devmadhuu (via GitHub)" <gi...@apache.org>.
devmadhuu commented on PR #5521:
URL: https://github.com/apache/ozone/pull/5521#issuecomment-1903334621
@smitajoshi12 Can you update your screenshots with proper API response ? Not sure why replicated data size is zero for the directories pending for deletion ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9085. Recon Directories Pending for Deletion Inside OMDB Insight [ozone]
Posted by "smitajoshi12 (via GitHub)" <gi...@apache.org>.
smitajoshi12 commented on code in PR #5521:
URL: https://github.com/apache/ozone/pull/5521#discussion_r1461892866
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/insights/om/om.tsx:
##########
@@ -777,6 +820,66 @@ export class Om extends React.Component<Record<string, object>, IOmdbInsightsSta
});
};
+ // Pending Delete Directories
+ fetchDeletePendingDir = (limit: number, prevKeyDirDelete: string) => {
+ this.setState({
+ loading: true,
+ nextClickable: true,
+ prevClickable: true
+ });
+
+ //Cancel any previous pending request
+ cancelRequests([
+ cancelMismatchedEndpointSignal,
+ cancelOpenKeysSignal,
+ cancelDeletePendingSignal,
+ cancelDeletedKeysSignal,
+ cancelRowExpandSignal,
+ cancelDeletedPendingDirSignal
+ ]);
+
+ let deletePendingDirEndpoint;
+ if (prevKeyDirDelete === "" || prevKeyDirDelete === undefined ) {
+ deletePendingDirEndpoint = `/api/v1/keys/deletePending/dirs?limit=${limit}`;
+ }
+ else {
+ deletePendingDirEndpoint = `/api/v1/keys/deletePending/dirs?limit=${limit}&prevKey=${prevKeyDirDelete}`;
+ }
+
+ const { request, controller } = AxiosGetHelper(deletePendingDirEndpoint, cancelDeletedPendingDirSignal);
+ cancelDeletedPendingDirSignal = controller
+ request.then(deletePendingDirResponse => {
+ const deletedDirInfo = deletePendingDirResponse && deletePendingDirResponse.data && deletePendingDirResponse.data.deletedDirInfo;
+ if (deletePendingDirResponse && deletePendingDirResponse.data && deletePendingDirResponse.data.lastKey === "") {
+ //last key of api is empty may be last record no further records
+ dirPendingPrevList =[""];
+ this.setState({
+ loading: false,
+ nextClickable: false,
+ pendingDeleteDirDataSource: deletedDirInfo
+ })
+ }
+ else {
+ if (this.state.prevKeyDirDelete === "" || this.state.prevKeyDirDelete === undefined ) {
+ this.setState({ prevClickable: false })
+ }
+ if (dirPendingPrevList.includes(deletePendingDirResponse.data.lastKey) === false) {
+ dirPendingPrevList.push(deletePendingDirResponse.data.lastKey);
+ }
Review Comment:
Yes Need to change logic once this PR gets merged. once https://github.com/apache/ozone/pull/5658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9085. Recon Directories Pending for Deletion Inside OMDB Insight [ozone]
Posted by "smitajoshi12 (via GitHub)" <gi...@apache.org>.
smitajoshi12 commented on code in PR #5521:
URL: https://github.com/apache/ozone/pull/5521#discussion_r1461891904
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/insights/om/om.tsx:
##########
@@ -777,6 +820,66 @@ export class Om extends React.Component<Record<string, object>, IOmdbInsightsSta
});
};
+ // Pending Delete Directories
+ fetchDeletePendingDir = (limit: number, prevKeyDirDelete: string) => {
Review Comment:
Done in latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org