You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2017/07/19 04:21:11 UTC

[GitHub] spark pull request #18388: [SPARK-21175] Reject OpenBlocks when memory short...

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18388#discussion_r128149914
  
    --- Diff: common/network-common/src/main/java/org/apache/spark/network/server/OneForOneStreamManager.java ---
    @@ -53,9 +56,13 @@
         // that the caller only requests each chunk one at a time, in order.
         int curChunk = 0;
     
    +    // Used to keep track of the number of chunks being transferred and not finished yet.
    +    AtomicLong chunksBeingTransferred;
    --- End diff --
    
    according to you usage, seems `volatile long chunksBeingTransferred` is enough?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org