[jira] [Commented] (MRESOLVER-321) Resolver while collecting may end up in busy loop without any possibility to be stopped

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MRESOLVER-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790038#comment-17790038 ] 

ASF GitHub Bot commented on MRESOLVER-321:
------------------------------------------

cstamas opened a new pull request, #380:
URL: https://github.com/apache/maven-resolver/pull/380

   Currently the two collection are not interruptable, does not sense interruption directly, only by some side-effect like IO. Moreover, the BF new collector may enter a "busy loop" as we seen, true, it was
   due bug, but nothing prevents us to have more bugs.
   
   Make main loop in both collector detect thread interruption and use global (per-collection) Args to carry state of the, interruption effectively the whole ST or MT
   collection.
   
   ---
   
   https://issues.apache.org/jira/browse/MRESOLVER-321




> Resolver while collecting may end up in busy loop without any possibility to be stopped
> ---------------------------------------------------------------------------------------
>
>                 Key: MRESOLVER-321
>                 URL: https://issues.apache.org/jira/browse/MRESOLVER-321
>             Project: Maven Resolver
>          Issue Type: Improvement
>          Components: Resolver
>            Reporter: Tamas Cservenak
>            Priority: Major
>             Fix For: 2.0.0
>
>
> As reported by users, under some conditions (MRESOLVER-316) resolver is able to spin itself into busy loop, without possibility to stop it (ie. by interrupting the thread of it).
> Example report: [https://github.com/apache/maven-resolver/pull/236]
> The reproducer (until MRESOLVER-316 is fixed) is present in PR above (the demo code and the diff for it).
> While the PR proposes a code change, that is not covering all, as in case of MRESOLVER-316 bug, the endless loop happens in visitor bit (DependencyVisitor visiting DependencyNodes).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)