You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/11/29 14:17:38 UTC

[GitHub] zhijiangW opened a new pull request #7199: [FLINK-10662][network] Refactor the ChannelSelector interface for single selected channel

zhijiangW opened a new pull request #7199: [FLINK-10662][network] Refactor the ChannelSelector interface for single selected channel
URL: https://github.com/apache/flink/pull/7199
 
 
   ## What is the purpose of the change
   
   *In `ChannelSelector#selectChannels`, it would return an array for selected channels. But considering specific implementations, only `BroadcastPartitioner` would select all the channels, and other implementations will select one channel.*
    
   *So we can simple this interface to return single channel index for benefiting performance, and specialize the `BroadcastPartitioner` in a more efficient way.*
   
   ## Brief change log
   
     - *Refactor the `selectChannel` method in `ChannelSelector` interface*
     - *Adjust the related processes in `RecordWriter`*
     - *Fix the related tests because of interface change*
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as *OutputEmitterTest* and *RecordWriterTest*.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (yes)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services